Skip to contentSkip to conversation

ceph: convert comma to semicolon

PATCH Applied Himangi Saraogi 2 participants 2 messages Jul 23, 2014 – Jul 24, 2014 Ceph client

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ceph: convert comma to semicolon

Replace a comma between expression statements by a semicolon. This changes the semantics of the code, but given the current indentation appears to be what is intended.

A simplified version of the Coccinelle semantic patch that performs this transformation is as follows:
// <smpl>
@r@
expression e1,e2;
@@

e1
-,
+;
e2;
// </smpl>

---
 fs/ceph/caps.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/ceph/caps.c +1 -1
index 1fde164..6d1cd45 100644
@@ -3277,7 +3277,7 @@ int ceph_encode_inode_release(void **p, struct inode *inode,
 			rel->ino = cpu_to_le64(ceph_ino(inode));
 			rel->cap_id = cpu_to_le64(cap->cap_id);
 			rel->seq = cpu_to_le32(cap->seq);
-			rel->issue_seq = cpu_to_le32(cap->issue_seq),
+			rel->issue_seq = cpu_to_le32(cap->issue_seq);
 			rel->mseq = cpu_to_le32(cap->mseq);
 			rel->caps = cpu_to_le32(cap->implemented);
 			rel->wanted = cpu_to_le32(cap->mds_wanted);
Signature · 1 line
1.9.1
Applied
#1 lore raw
Quoted 11 lines · Himangi Saraogi

Replace a comma between expression statements by a semicolon. This changes the semantics of the code, but given the current indentation appears to be what is intended.

A simplified version of the Coccinelle semantic patch that performs this transformation is as follows:
// <smpl>
@r@
expression e1,e2;
@@

Quoted 8 lines

e1
-,
+;
e2;
// </smpl>

Applied.

Thanks,

Ilya