Skip to contentSkip to conversation

x86: drop extra semi-colon in caa_cpu_relax

PATCH Mathieu Desnoyers 1 participant 1 message Jul 31, 2014 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

----- Original Message -----

Quoted 13 lines

From: "Eric Wong" <[email protected]>
To: "Mathieu Desnoyers" <[email protected]>
Cc: [email protected]
Sent: Wednesday, July 30, 2014 8:21:51 PM
Subject: [PATCH urcu] x86: drop extra semi-colon in caa_cpu_relax

This fixes compilation in braceless if/else constructs:

	if (expr)
		caa_cpu_relax();
	else
		...
Quoted 5 lines

---
Btw, did you notice my rculfhash patches last month. I just realize I forgot to Cc you directly. Thanks for URCU!

Hi Eric,

Patch merged, thanks!

Yes, I've seen them in my inbox, but was unfortunately very busy at the time. Thanks for the reminder!

Mathieu

Quoted 20 lines
 urcu/arch/x86.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
urcu/arch/x86.h +1 -2
index 7af1ca5..ccc4ce8 100644
@@ -66,7 +66,7 @@ extern "C" {
 #endif
 #endif
 
-#define caa_cpu_relax()	__asm__ __volatile__ ("rep; nop" : : : "memory");
+#define caa_cpu_relax()	__asm__ __volatile__ ("rep; nop" : : : "memory")
 
 #define rdtscll(val)							  \
 	do {						  		  \
--

EW

Signature · 3 lines
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com