Skip to contentSkip to conversation

ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers

DISCUSSION Dan Carpenter 1 participant 1 message Jul 31, 2014

lore
Share & tools
lore
#0 lore raw

Hello Nicolin Chen,

This is a semi-automatic email about new static checker warnings.

The patch 3117bb3109dc: "ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers" from Jul 29, 2014, leads to the following Smatch complaint:

sound/soc/fsl/fsl_asrc_dma.c:304 fsl_asrc_dma_shutdown()
warn: variable dereferenced before check 'pair' (see line 302)

sound/soc/fsl/fsl_asrc_dma.c
301 struct fsl_asrc_pair *pair = runtime->private_data;

   302		struct fsl_asrc *asrc_priv = pair->asrc_priv;
                                             ^^^^^^^^^^^^^^^

Dereference.

   303	
   304		if (pair && asrc_priv->pair[pair->index] == pair)
                    ^^^^

Check.

   305			asrc_priv->pair[pair->index] = NULL;
   306	

regards,
dan carpenter