Build Error in Linux-next, intel ethernet driver
Subsystems (2)
I updated my clean untouched linux-next tree, and tried to compile with the attached .config. But I got a build error with intel i40e driver.
I tested a fix, and sent to LKML. But I don't have this device, I compiled and tested the kernel. Boots normally.
Anyone had the same issue ?
Thanks
Lucas Tanure
Fix missing include in intel i40e driver. Without this include linux next tree won't compile.
--- drivers/net/ethernet/intel/i40e/i40e_fcoe.c | 1 + 1 file changed, 1 insertion(+)
drivers/net/ethernet/intel/i40e/i40e_fcoe.c +1 -0
@@ -33,6 +33,7 @@#include <scsi/fc/fc_fcoe.h> #include <scsi/libfc.h> #include <scsi/libfcoe.h> +#include <uapi/linux/dcbnl.h> #include "i40e.h" #include "i40e_fcoe.h"
6,635 lines not shown · raw message
Part of this message is not shown here. View the raw message.
I updated my clean untouched linux-next tree, and tried to compile with the attached .config.
But I got a build error with intel i40e driver.
I tested a fix, and sent to LKML. But I don't have this device, I compiled and tested the kernel.
Boots normally.
Anyone had the same issue ?
Thanks
Lucas Tanure
Fix missing include in intel i40e driver. Without this include linux next tree won't compile.
--- drivers/net/ethernet/intel/i40e/i40e_fcoe.c | 1 + 1 file changed, 1 insertion(+)
(quoted diff) +0 -0
b/drivers/net/ethernet/intel/i40e/i40e_fcoe.c
index 6938fc1..5d01db1 100644
drivers/net/ethernet/intel/i40e/i40e_fcoe.c +1 -0
@@ -33,6 +33,7 @@#include <scsi/fc/fc_fcoe.h> #include <scsi/libfc.h> #include <scsi/libfcoe.h> +#include <uapi/linux/dcbnl.h> #include "i40e.h" #include "i40e_fcoe.h"
Signature · 1 line
2.0.0
Quoted 2 lines · Lucas Tanure
I updated my clean untouched linux-next tree, and tried to compile with the attached .config.
Your .config got stripped from the mail, can you please send me your .config.
Quoted 7 lines
But I got a build error with intel i40e driver.
I tested a fix, and sent to LKML. But I don't have this device, I compiled and tested the kernel.
Boots normally.Anyone had the same issue ?
I have not been testing linux-next, but I do test David Miller's net-next and net tree's which compile just fine with allmodconfig. In the short term, I have added your patch to my queue so that our validation team can take a look at the issue. Please send me your .config so that we can reproduce your issue to ensure that your patch is the best solution for this issue.
Quoted 27 lines
Thanks
Lucas TanureFix missing include in intel i40e driver. Without this include linux next tree won't compile.
Signed-off-by Lucas Tanure <[email protected]>--- drivers/net/ethernet/intel/i40e/i40e_fcoe.c | 1 + 1 file changed, 1 insertion(+)drivers/net/ethernet/intel/i40e/i40e_fcoe.c +1
-1@@ -33,6 +33,7 @@#include <scsi/fc/fc_fcoe.h> #include <scsi/libfc.h> #include <scsi/libfcoe.h> +#include <uapi/linux/dcbnl.h> #include "i40e.h" #include "i40e_fcoe.h" --
Hi,
Thanks for reviewing my patch. My .config was bigger than 40k ( max attachment size for kernelnewbies list).
The quick way to share is through dropbox.
https://www.dropbox.com/s/kyeecunmebouysk/config.xz
Thanks
--
Lucas Tanure
+55 (19) 988176559
Quoted 48 lines · Jeff Kirsher
Quoted 2 lines · Lucas Tanure
I updated my clean untouched linux-next tree, and tried to compile with the attached .config.
Your .config got stripped from the mail, can you please send me your .config.
Quoted 7 lines
But I got a build error with intel i40e driver.
I tested a fix, and sent to LKML. But I don't have this device, I compiled and tested the kernel.
Boots normally.Anyone had the same issue ?
I have not been testing linux-next, but I do test David Miller's net-next and net tree's which compile just fine with allmodconfig. In the short term, I have added your patch to my queue so that our validation team can take a look at the issue. Please send me your .config so that we can reproduce your issue to ensure that your patch is the best solution for this issue.
Quoted 27 lines
Thanks
Lucas TanureFix missing include in intel i40e driver. Without this include linux next tree won't compile.
Signed-off-by Lucas Tanure <[email protected]>--- drivers/net/ethernet/intel/i40e/i40e_fcoe.c | 1 + 1 file changed, 1 insertion(+)drivers/net/ethernet/intel/i40e/i40e_fcoe.c +1
-1@@ -33,6 +33,7 @@#include <scsi/fc/fc_fcoe.h> #include <scsi/libfc.h> #include <scsi/libfcoe.h> +#include <uapi/linux/dcbnl.h> #include "i40e.h" #include "i40e_fcoe.h" --
Quoted 2 lines · Lucas Tanure
Thanks for reviewing my patch. My .config was bigger than 40k ( max attachment size for kernelnewbies list).
First thing I noticed was that your config was missing CONFIG_I40E_DCB=y option. So it appears that some of the recent FCoE code that was added to the i40e driver needs to be wrapped with #ifdef CONFIG_I40E_DCB.
Can you provide the error that you are receiving, without your patch
applied? That will help me narrow down what code needs to be wrapped.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
Url : http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20140805/52b23ae5/attachment-0001.bin
of course
drivers/net/ethernet/intel/i40e/i40e_fcoe.c: In function ?i40e_get_fcoe_tc_map?:drivers/net/ethernet/intel/i40e/i40e_fcoe.c:354:23: error:
?IEEE_8021QAZ_APP_SEL_ETHERTYPE? undeclared (first use in this function)
if (app.selector == IEEE_8021QAZ_APP_SEL_ETHERTYPE &&
^
drivers/net/ethernet/intel/i40e/i40e_fcoe.c:354:23: note: each undeclared identifier is reported only once for each function it appears inscripts/Makefile.build:257: recipe for target 'drivers/net/ethernet/intel/i40e/i40e_fcoe.o' failed make[5]: *** [drivers/net/ethernet/intel/i40e/i40e_fcoe.o] Error 1 scripts/Makefile.build:404: recipe for target 'drivers/net/ethernet/intel/i40e' failed
make[4]: *** [drivers/net/ethernet/intel/i40e] Error 2 scripts/Makefile.build:404: recipe for target 'drivers/net/ethernet/intel' failed
make[3]: *** [drivers/net/ethernet/intel] Error 2 make[3]: *** Waiting for unfinished jobs....
Thanks
--
Lucas Tanure
+55 (19) 988176559
Quoted 10 lines · Jeff Kirsher
Quoted 2 lines · Lucas Tanure
Thanks for reviewing my patch. My .config was bigger than 40k ( max attachment size for kernelnewbies list).
First thing I noticed was that your config was missing
CONFIG_I40E_DCB=yoption. So it appears that some of the recent FCoE code that was added to the i40e driver needs to be wrapped with #ifdefCONFIG_I40E_DCB.Can you provide the error that you are receiving, without your patch applied? That will help me narrow down what code needs to be wrapped.