usb: phy: drop kfree of devm_kzalloc's data
PATCH 1/1 usb: phy: drop kfree of devm_kzalloc's data
Using kfree to free data allocated with devm_kzalloc causes double frees.
The Coccinelle semantic patch that fixes this problem is as follows:
// <smpl>
@@
expression x;
@@
x = devm_kzalloc(...)
...
?-kfree(x);
// </smpl>
Signed-off-by Himangi Saraogi <[email protected]>
Acked-by Julia Lawall <[email protected]>
--- drivers/usb/phy/phy-gpio-vbus-usb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/usb/phy/phy-gpio-vbus-usb.c +1 -3
@@ -260,10 +260,8 @@ static int gpio_vbus_probe(struct platform_device *pdev) gpio_vbus->phy.otg =devm_kzalloc (&pdev->dev,sizeof (struct usb_otg ),GFP_KERNEL ); -if (!gpio_vbus->phy.otg) { -kfree (gpio_vbus); +if (!gpio_vbus->phy.otg)return -ENOMEM ; - }platform_set_drvdata (pdev, gpio_vbus); gpio_vbus->dev = &pdev->dev;
Signature · 1 line
1.9.1
Quoted 10 lines · Himangi Saraogi
Using kfree to free data allocated with
devm_kzalloccauses double frees.The Coccinelle semantic patch that fixes this problem is as follows:
// <smpl>
@@
expression x;
@@
Quoted 7 lines
x =
devm_kzalloc(...)
...
?-kfree(x);
// </smpl>Signed-off-by Himangi Saraogi <[email protected]>Acked-by Julia Lawall <[email protected]>
Reviewed-by Jingoo Han <[email protected]>
Best regards,
Jingoo Han
Quoted 22 lines
--- drivers/usb/phy/phy-gpio-vbus-usb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/usb/phy/phy-gpio-vbus-usb.c +1
-4@@ -260,10 +260,8 @@ static int gpio_vbus_probe(struct platform_device *pdev) gpio_vbus->phy.otg =devm_kzalloc (&pdev->dev,sizeof (struct usb_otg ),GFP_KERNEL ); -if (!gpio_vbus->phy.otg) { -kfree (gpio_vbus); +if (!gpio_vbus->phy.otg)return -ENOMEM ; - }platform_set_drvdata (pdev, gpio_vbus); gpio_vbus->dev = &pdev->dev; --1.9.1