qib_keys: Replace rcu_assign_pointer() with RCU_INIT_POINTER()
PATCH 1/1 qib_keys: Replace rcu_assign_pointer() with RCU_INIT_POINTER()
The uses of "rcu_assign_pointer()" are NULLing out the pointers. According to RCU_INIT_POINTER()'s block comment:
"1. This use of RCU_INIT_POINTER() is NULLing out the pointer"
it is better to use it instead of rcu_assign_pointer() because it has a smaller overhead.
The following Coccinelle semantic patch was used:
@@
@@
- rcu_assign_pointer
+ RCU_INIT_POINTER
(..., NULL)
--- drivers/infiniband/hw/qib/qib_keys.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/infiniband/hw/qib/qib_keys.c +2 -2
@@ -122,10 +122,10 @@ void qib_free_lkey(struct qib_mregion *mr)if (!mr->lkey_published) goto out;if (lkey ==0 ) -rcu_assign_pointer (dev->dma_mr,NULL ); +RCU_INIT_POINTER (dev->dma_mr,NULL );else { r = lkey >> (32 - ib_qib_lkey_table_size); -rcu_assign_pointer (rkt->table[r],NULL ); +RCU_INIT_POINTER (rkt->table[r],NULL ); }qib_put_mr (mr); mr->lkey_published =0 ;
Signature · 6 lines
1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 3 lines
Subject: [PATCH]
qib_keys: Replacercu_assign_pointer()withRCU_INIT_POINTER()
I would prefer the summary be:
IB/qib: qib_remove_lkey() Replace rcu_assign_pointer() with
Quoted 1 line
RCU_INIT_POINTER()
Otherwise the patch looks ok and has been tested.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html