Skip to contentSkip to conversation

buildman: make-flags variables broken?

U-Boot Tom Rini 2 participants 4 messages Aug 22, 2014 – Aug 23, 2014

lore
Share & tools
lore

Tom Rini

author
#0 lore raw

Hey,

In adding an env-flags section for buildman and trying to test out my docs, I think I found that the following doesn't work today:
[make-flags]
mipsel-boards=1=2 2=3
qemu_mipsel=${mipsel-boards} 4=5

With a:

tools/buildman/builderthread.py +1 -0
index 920752c..77118e4 100644
@@ -203,6 +203,7 @@ class BuilderThread(threading.Thread):
                 config_args = ['%s_defconfig' % brd.target]
                 config_out = ''
                 args.extend(self.builder.toolchains.GetMakeArguments(brd))
+                print args

I get:
['O=build', '-s', '-j', '9', '${mipsel-boards}', '4=5']

as the output.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140822/caebab4f/attachment.pgp>
#1 lore raw

Hi Tom,

Quoted 23 lines · Tom Rini

Hey,

In adding an env-flags section for buildman and trying to test out my docs, I think I found that the following doesn't work today:
[make-flags]
mipsel-boards=1=2 2=3
qemu_mipsel=${mipsel-boards} 4=5

With a:

tools/buildman/builderthread.py +1 -0
index 920752c..77118e4 100644
@@ -203,6 +203,7 @@ class BuilderThread(threading.Thread):
                 config_args = ['%s_defconfig' % brd.target]
                 config_out = ''
                 args.extend(self.builder.toolchains.GetMakeArguments(brd))
+                print args

I get:
['O=build', '-s', '-j', '9', '${mipsel-boards}', '4=5']

Quoted 1 line

as the output.

I have a little list of buiidman/patman things so will add this. I have not had much time this week and want to figure out the bootm stuff first. But will get it to it in the next few days.

Regards,
Simon

#2 lore raw

Hi Tom,

Quoted 23 lines · Simon Glass

Hi Tom,

Quoted 20 lines · Tom Rini

Hey,

In adding an env-flags section for buildman and trying to test out my docs, I think I found that the following doesn't work today:
[make-flags]
mipsel-boards=1=2 2=3
qemu_mipsel=${mipsel-boards} 4=5

With a:

tools/buildman/builderthread.py +1 -0
index 920752c..77118e4 100644
@@ -203,6 +203,7 @@ class BuilderThread(threading.Thread):
                 config_args = ['%s_defconfig' % brd.target]
                 config_out = ''
                 args.extend(self.builder.toolchains.GetMakeArguments(brd))
+                print args
Quoted 8 lines
Quoted 4 lines

I get:
['O=build', '-s', '-j', '9', '${mipsel-boards}', '4=5']

as the output.

I have a little list of buiidman/patman things so will add this. I have not had much time this week and want to figure out the bootm stuff first. But will get it to it in the next few days.

The problem is that buildman does not support - and _ in the variables. I'll add this in a new patch.

Regards,
Simon

author
#3 lore raw
Quoted 29 lines · Simon Glass

Hi Tom,

Quoted 26 lines · Simon Glass

Hi Tom,

Quoted 23 lines · Tom Rini

Hey,

In adding an env-flags section for buildman and trying to test out my docs, I think I found that the following doesn't work today:
[make-flags]
mipsel-boards=1=2 2=3
qemu_mipsel=${mipsel-boards} 4=5

With a:

tools/buildman/builderthread.py +1 -0
index 920752c..77118e4 100644
@@ -203,6 +203,7 @@ class BuilderThread(threading.Thread):
                 config_args = ['%s_defconfig' % brd.target]
                 config_out = ''
                 args.extend(self.builder.toolchains.GetMakeArguments(brd))
+                print args

I get:
['O=build', '-s', '-j', '9', '${mipsel-boards}', '4=5']

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

as the output.

I have a little list of buiidman/patman things so will add this. I have not had much time this week and want to figure out the bootm stuff first. But will get it to it in the next few days.

The problem is that buildman does not support - and _ in the variables. I'll add this in a new patch.

Ah, OK. I was just following the docs of course :)

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140823/f35e524f/attachment.pgp>