Skip to contentSkip to conversation

fs: aio: Replace rcu_assign_pointer() with RCU_INIT_POINTER()

PATCH New Andreea-Cristina Bernat 1 participant 1 message Aug 22, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fs: aio: Replace rcu_assign_pointer() with RCU_INIT_POINTER()

The use of "rcu_assign_pointer()" is NULLing out the pointer. According to RCU_INIT_POINTER()'s block comment:
"1. This use of RCU_INIT_POINTER() is NULLing out the pointer"
it is better to use it instead of rcu_assign_pointer() because it has a smaller overhead.

The following Coccinelle semantic patch was used:
@@
@@

- rcu_assign_pointer
+ RCU_INIT_POINTER
(..., NULL)

---
 fs/aio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/aio.c +1 -1
index 4f078c0..81f7f3f 100644
@@ -802,7 +802,7 @@ void exit_aio(struct mm_struct *mm)
 		do {
 			if (!table || i >= table->nr) {
 				rcu_read_unlock();
-				rcu_assign_pointer(mm->ioctx_table, NULL);
+				RCU_INIT_POINTER(mm->ioctx_table, NULL);
 				if (table)
 					kfree(table);
 				return;
Signature · 7 lines
1.9.1

--
To unsubscribe, send a message with 'unsubscribe linux-aio' in
the body to [email protected].  For more info on Linux AIO,
see: http://www.kvack.org/aio/
Don't email: <a href=mailto:"[email protected]">[email protected]</a>