Skip to contentSkip to conversation

kernel: sched: fair: Replace rcu_assign_pointer() with RCU_INIT_POINTER()

PATCH RESEND New Andreea-Cristina Bernat 2 participants 2 messages Aug 22, 2014 – Sep 5, 2014 Scheduler

lore
Share & tools
lore

Andreea-Cristina Bernat

author
#0 lore raw

PATCH RESEND 1/1 kernel: sched: fair: Replace rcu_assign_pointer() with RCU_INIT_POINTER()

The use of "rcu_assign_pointer()" is NULLing out the pointer. According to RCU_INIT_POINTER()'s block comment:
"1. This use of RCU_INIT_POINTER() is NULLing out the pointer"
it is better to use it instead of rcu_assign_pointer() because it has a smaller overhead.

The following Coccinelle semantic patch was used:
@@
@@

- rcu_assign_pointer
+ RCU_INIT_POINTER
(..., NULL)

Signed-off-by Andreea-Cristina Bernat <[email protected]>
---
 kernel/sched/fair.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/sched/fair.c +1 -1
index fea7d33..7d4f743 100644
@@ -1759,7 +1759,7 @@ void task_numa_free(struct task_struct *p)
 		list_del(&p->numa_entry);
 		grp->nr_tasks--;
 		spin_unlock_irqrestore(&grp->lock, flags);
-		rcu_assign_pointer(p->numa_group, NULL);
+		RCU_INIT_POINTER(p->numa_group, NULL);
 		put_numa_group(grp);
 	}
Signature · 1 line
1.9.1
merge bot
#1 lore raw

[tip:sched/core] sched/fair: Replace rcu_assign_pointer() with RCU_INIT_POINTER()

sched/fair: Replace rcu_assign_pointer() with RCU_INIT_POINTER()
Commit-ID:  35b123e2f701b28977db2cde7dbbdb3fad28cad1
Gitweb:     http://git.kernel.org/tip/35b123e2f701b28977db2cde7dbbdb3fad28cad1
Author:     Andreea-Cristina Bernat <[email protected]>
AuthorDate: Fri, 22 Aug 2014 17:50:43 +0300
Committer:  Ingo Molnar <[email protected]>
CommitDate: Fri, 5 Sep 2014 08:11:57 +0200

sched/fair: Replace rcu_assign_pointer() with RCU_INIT_POINTER()

The use of "rcu_assign_pointer()" is NULLing out the pointer. According to RCU_INIT_POINTER()'s block comment:

"1. This use of RCU_INIT_POINTER() is NULLing out the pointer"

it is better to use it instead of rcu_assign_pointer() because it has a smaller overhead.

The following Coccinelle semantic patch was used:
@@
@@

- rcu_assign_pointer
+ RCU_INIT_POINTER
(..., NULL)

Signed-off-by Andreea-Cristina Bernat <[email protected]>
Signed-off-by Peter Zijlstra (Intel) <[email protected]>
Cc [email protected]
Cc Linus Torvalds <[email protected]>
Link http://lkml.kernel.org/r/20140822145043.GA580@ada open here
Signed-off-by Ingo Molnar <[email protected]>
---
 kernel/sched/fair.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/sched/fair.c +1 -1
index d3427a8..02fc949 100644
@@ -1780,7 +1780,7 @@ void task_numa_free(struct task_struct *p)
 		list_del(&p->numa_entry);
 		grp->nr_tasks--;
 		spin_unlock_irqrestore(&grp->lock, flags);
-		rcu_assign_pointer(p->numa_group, NULL);
+		RCU_INIT_POINTER(p->numa_group, NULL);
 		put_numa_group(grp);
 	}