mmc: mmci: Add qcom dml support to the driver.
Hello Srinivas Kandagatla,
The patch 4dd5a1e6dd12: "mmc: mmci: Add qcom dml support to the driver." from Jul 29, 2014, leads to the following static checker warning:
drivers/mmc/host/mmci_qcom_dml.c:131 dml_hw_init() warn: unsigned 'producer_id' is never less than zero.
drivers/mmc/host/mmci_qcom_dml.c
121 /* Initialize the dml hardware connected to SD Card controller */
122 int dml_hw_init(struct mmci_host *host, struct device_node *np)
123 {
124 u32 config;
125 void __iomem *base;
126 u32 consumer_id, producer_id;
127
128 consumer_id = of_get_dml_pipe_index(np, "tx");
129 producer_id = of_get_dml_pipe_index(np, "rx");
130
131 if (producer_id < 0 || consumer_id < 0)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 132 return -ENODEV;
133
regards,
dan carpenter
Hi Dan,
Thankyou for reporting this warning.
Both consumer_id and producer_id are supposed to be int instead of u32. I will fix this.
Thanks,
srini
Quoted 28 lines · Dan Carpenter
Hello Srinivas Kandagatla,
The patch
4dd5a1e6dd12: "mmc: mmci: Add qcom dml support to the driver." from Jul 29, 2014, leads to the following static checker warning:drivers/mmc/host/mmci_qcom_dml.c:131 dml_hw_init() warn: unsigned 'producer_id' is never less than zero.
drivers/mmc/host/mmci_qcom_dml.c121 /* Initialize the dml hardware connected to SD Card controller */ 122 int dml_hw_init(struct mmci_host *host, struct device_node *np) 123 { 124 u32 config; 125 void __iomem *base; 126 u32 consumer_id, producer_id; 127 128 consumer_id = of_get_dml_pipe_index(np, "tx"); 129 producer_id = of_get_dml_pipe_index(np, "rx"); 130 131 if (producer_id < 0 || consumer_id < 0) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 132 return -ENODEV; 133regards,
dan carpenter