Skip to contentSkip to conversation

How should NAND_CMD_LOCK_TIGHT be handled ?

U-Boot Masahiro Yamada 1 participant 1 message Aug 29, 2014

lore
Share & tools
lore
#0 lore raw

Hi, Scott and other MTD developers,

Commit ff94bc40af3481d47546595ba73c136de6af6929
(mtd, ubi, ubifs: resync with Linux-3.14)
moved the definition of NAND_CMD_LOCK_TIGHT and NAND_CMD_LOCK_STATUS from include/mtd/nand/ to drivers/mtd/nand/nand_util.c

(These two macros looks like U-Boot specific extentions.)

Since that commit, Denali driver cannot build
http://patchwork.ozlabs.org/patch/381305/

CC drivers/mtd/nand/denali.o
drivers/mtd/nand/denali.c: In function 'denali_cmdfunc':
drivers/mtd/nand/denali.c:1107:7: error: 'NAND_CMD_LOCK_TIGHT' undeclared (first use in this function) drivers/mtd/nand/denali.c:1107:7: note: each undeclared identifier is reported only once for each function it appears in make[1]: *** [drivers/mtd/nand/denali.o] Error 1
make: *** [drivers/mtd/nand] Error 2

My question is:

- What is this macro? Why was it added to U-Boot?

- If this macro is still necessary, shouldn't it be defined globally?

Best Regards
Masahiro Yamada