Skip to contentSkip to conversation

ARM: shmobile: lager: Remove legacy C board code

PATCH In review Magnus Damm 4 participants 11 messages Sep 4, 2014 – Sep 10, 2014

Subsystems (4)
Arm (32-bit) Arm sub-architectures SuperH Arm/RISC-V/Renesas architecture
lore
Share & tools
lore

Magnus Damm

author maintainer
#0 lore raw

PATCH 1/1 ARM: shmobile: lager: Remove legacy C board code

From: Magnus Damm <[email protected]>

The Multiplatform r8a7790 Lager board code is at this point in equally or better state compared to the legacy code.

Because of that it is now a good time to get rid of the old code and force all users move over to Multiplatform.

Signed-off-by Magnus Damm <[email protected]>

---

Built on top of renesas-devel-20140904-v3.17-rc3 and "[PATCH 00/03] ARM: shmobile: sh73a0 and kzm9g Multiplatform support"

 arch/arm/mach-shmobile/Kconfig       |    7 
 arch/arm/mach-shmobile/Makefile      |    1 
 arch/arm/mach-shmobile/Makefile.boot |    1 
 arch/arm/mach-shmobile/board-lager.c |  892 ----------------------------------
 4 files changed, 901 deletions(-)
arch/arm/mach-shmobile/Kconfig +0 -7
@@ -236,13 +236,6 @@ config MACH_MARZEN
 	select REGULATOR_FIXED_VOLTAGE if REGULATOR
 	select USE_OF
 
-config MACH_LAGER
-	bool "Lager board"
-	depends on ARCH_R8A7790
-	select USE_OF
-	select MICREL_PHY if SH_ETH
-	select SND_SOC_AK4642 if SND_SIMPLE_CARD
-
 config MACH_KOELSCH
 	bool "Koelsch board"
 	depends on ARCH_R8A7791
arch/arm/mach-shmobile/Makefile +0 -1
@@ -66,7 +66,6 @@ obj-$(CONFIG_MACH_MACKEREL)	+= board-mac
 obj-$(CONFIG_MACH_BOCKW)	+= board-bockw.o
 obj-$(CONFIG_MACH_BOCKW_REFERENCE)	+= board-bockw-reference.o
 obj-$(CONFIG_MACH_MARZEN)	+= board-marzen.o
-obj-$(CONFIG_MACH_LAGER)	+= board-lager.o
 obj-$(CONFIG_MACH_ARMADILLO800EVA)	+= board-armadillo800eva.o
 obj-$(CONFIG_MACH_ARMADILLO800EVA_REFERENCE)	+= board-armadillo800eva-reference.o
 obj-$(CONFIG_MACH_KOELSCH)	+= board-koelsch.o
arch/arm/mach-shmobile/Makefile.boot +0 -1
@@ -9,7 +9,6 @@ loadaddr-$(CONFIG_MACH_BOCKW_REFERENCE)
 loadaddr-$(CONFIG_MACH_KOELSCH) += 0x40008000
 loadaddr-$(CONFIG_MACH_KZM9G) += 0x41008000
 loadaddr-$(CONFIG_MACH_KZM9G_REFERENCE) += 0x41008000
-loadaddr-$(CONFIG_MACH_LAGER) += 0x40008000
 loadaddr-$(CONFIG_MACH_MACKEREL) += 0x40008000
 loadaddr-$(CONFIG_MACH_MARZEN) += 0x60008000
arch/arm/mach-shmobile/board-lager.c deleted +0 -891

891 lines not on this page · raw message

#1 lore raw

Hi Magnus,

Thank you for the patch.

Quoted 4 lines · On Thursday 04 September 2014 11:34:40 Magnus Damm wrote:

From: Magnus Damm <[email protected]>

The Multiplatform r8a7790 Lager board code is at this point in equally or better state compared to the legacy code.

Don't we miss support for USBHS and sound with multiplatform Lager ? Did you maybe mean to remove the Koelsch legacy board code ?

Quoted 14 lines

Because of that it is now a good time to get rid of the old code and force all users move over to Multiplatform.

Signed-off-by Magnus Damm <[email protected]>

---

Built on top of renesas-devel-20140904-v3.17-rc3 and "[PATCH 00/03] ARM: shmobile: sh73a0 and kzm9g Multiplatform support"

 arch/arm/mach-shmobile/Kconfig       |    7
 arch/arm/mach-shmobile/Makefile      |    1
 arch/arm/mach-shmobile/Makefile.boot |    1
 arch/arm/mach-shmobile/board-lager.c |  892 -------------------------------
 4 files changed, 901 deletions(-)
Signature · 3 lines
Regards,

Laurent Pinchart
author maintainer
#2 lore raw
In reply to Magnus Damm

Hi Laurent,

Quoted 4 lines · Laurent Pinchart

Hi Magnus,

Thank you for the patch.

Quoted 8 lines
Quoted 4 lines · On Thursday 04 September 2014 11:34:40 Magnus Damm wrote:

From: Magnus Damm <[email protected]>

The Multiplatform r8a7790 Lager board code is at this point in equally or better state compared to the legacy code.

Don't we miss support for USBHS and sound with multiplatform Lager ? Did you maybe mean to remove the Koelsch legacy board code ?

I intend to remove both sooner or later, also including defconfigs.

But yes, DMA enabled sound is not yet there. And some USB bits.

It also collides with your DU DT patch series. How do we order all this, perhaps a discussion to have with Simon?

Cheers,

/ magnus

#3 lore raw
In reply to Magnus Damm

Hello.

Quoted 4 lines · Magnus Damm

From: Magnus Damm <[email protected]>

The Multiplatform r8a7790 Lager board code is at this point in equally or better state compared to the legacy code.

I think it's a bit premature to say this. For example, USBHS DT support
hasn't been merged (the .dts[i] part hasn't even been posted yet IIRC). The USB PHY DT support also hasn't been merged.

Quoted 4 lines

Because of that it is now a good time to get rid of the old code and force all users move over to Multiplatform.

Signed-off-by Magnus Damm <[email protected]>

WBR, Sergei

author maintainer
#4 lore raw
In reply to Magnus Damm

Hi Sergei,

Quoted 7 lines · Sergei Shtylyov

Hello.

Quoted 1 line · Magnus Damm

From: Magnus Damm <[email protected]>

Quoted 7 lines
Quoted 2 lines

The Multiplatform r8a7790 Lager board code is at this point in equally or better state compared to the legacy code.

I think it's a bit premature to say this. For example, USBHS DT support
hasn't been merged (the .dts[i] part hasn't even been posted yet IIRC). The USB PHY DT support also hasn't been merged.

Thanks for letting us know. It may be a bit early then.

Cheers,

/ magnus

#5 lore raw
In reply to Magnus Damm
Quoted 15 lines · Magnus Damm

Hi Sergei,

Quoted 11 lines · Sergei Shtylyov

Hello.

Quoted 5 lines · Magnus Damm

From: Magnus Damm <[email protected]>

The Multiplatform r8a7790 Lager board code is at this point in equally or better state compared to the legacy code.

Quoted 5 lines
Quoted 3 lines

I think it's a bit premature to say this. For example, USBHS DT support
hasn't been merged (the .dts[i] part hasn't even been posted yet IIRC). The USB PHY DT support also hasn't been merged.

Thanks for letting us know. It may be a bit early then.

At this point my feeling is that its better to wait if there are still features in Legacy-C that haven't made it across to multiplatform yet.

author maintainer
#6 lore raw
In reply to Magnus Damm

Hi Simon,

Quoted 16 lines · Simon Horman
Quoted 15 lines · Magnus Damm

Hi Sergei,

Quoted 11 lines · Sergei Shtylyov

Hello.

Quoted 5 lines · Magnus Damm

From: Magnus Damm <[email protected]>

The Multiplatform r8a7790 Lager board code is at this point in equally or better state compared to the legacy code.

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines

I think it's a bit premature to say this. For example, USBHS DT support
hasn't been merged (the .dts[i] part hasn't even been posted yet IIRC). The USB PHY DT support also hasn't been merged.

Thanks for letting us know. It may be a bit early then.

At this point my feeling is that its better to wait if there are still features in Legacy-C that haven't made it across to multiplatform yet.

I agree, waiting must be the best option. Thanks!

Cheers,

/ magnus

#7 lore raw
In reply to Magnus Damm
Quoted 23 lines · Magnus Damm

Hi Simon,

Quoted 20 lines · Simon Horman
Quoted 19 lines · Magnus Damm

Hi Sergei,

Quoted 14 lines · Sergei Shtylyov

Hello.

Quoted 5 lines · Magnus Damm

From: Magnus Damm <[email protected]>

The Multiplatform r8a7790 Lager board code is at this point in equally or better state compared to the legacy code.

I think it's a bit premature to say this. For example, USBHS DT support
hasn't been merged (the .dts[i] part hasn't even been posted yet IIRC). The USB PHY DT support also hasn't been merged.

Quoted 6 lines
Quoted 4 lines
Quoted 1 line

Thanks for letting us know. It may be a bit early then.

At this point my feeling is that its better to wait if there are still features in Legacy-C that haven't made it across to multiplatform yet.

I agree, waiting must be the best option. Thanks!

A general comment about removing board code:

As suggested by Arnd elsewhere, please also submit a patch to remove #ifdef CONFIG_USE_OF from the relevant setup-*.c file when you remove the legacy board code if the setup-*.c will thus always be compiled with ARCH_MULTIPLATFORM which selects CONFIG_USE_OF.

author maintainer
#8 lore raw
In reply to Magnus Damm

Hi Simon,

Quoted 29 lines · Simon Horman
Quoted 28 lines · Magnus Damm

Hi Simon,

Quoted 24 lines · Simon Horman
Quoted 15 lines · Magnus Damm

Hi Sergei,

Quoted 11 lines · Sergei Shtylyov

Hello.

Quoted 5 lines · Magnus Damm

From: Magnus Damm <[email protected]>

The Multiplatform r8a7790 Lager board code is at this point in equally or better state compared to the legacy code.

Quoted 5 lines
Quoted 3 lines

I think it's a bit premature to say this. For example, USBHS DT support
hasn't been merged (the .dts[i] part hasn't even been posted yet IIRC). The USB PHY DT support also hasn't been merged.

Thanks for letting us know. It may be a bit early then.

At this point my feeling is that its better to wait if there are still features in Legacy-C that haven't made it across to multiplatform yet.

Quoted 8 lines
Quoted 1 line

I agree, waiting must be the best option. Thanks!

A general comment about removing board code:

As suggested by Arnd elsewhere, please also submit a patch to remove #ifdef CONFIG_USE_OF from the relevant setup-*.c file when you remove the legacy board code if the setup-*.c will thus always be compiled with ARCH_MULTIPLATFORM which selects CONFIG_USE_OF.

Sure, of course. The main concern from my side was to introduce as few difficulties as ever possible merge-wise. I may have misunderstood things, but I thought having SoC cleanups that depend on Board cleanups in the same merge window may complicate the ARM SoC merge? Because of this a SoC cleanup like suggested above cannot easily depend on a board cleanup like the legacy board code removal patch. So my plan was to first remove the legacy board code in one merge window, and in the second one cleanup the SoC bits.

Please correct me if I'm wrong.

Cheers,

/ magnus

#9 lore raw
In reply to Magnus Damm
Quoted 50 lines · Magnus Damm

Hi Simon,

Quoted 29 lines · Simon Horman
Quoted 28 lines · Magnus Damm

Hi Simon,

Quoted 24 lines · Simon Horman
Quoted 15 lines · Magnus Damm

Hi Sergei,

Quoted 11 lines · Sergei Shtylyov

Hello.

Quoted 5 lines · Magnus Damm

From: Magnus Damm <[email protected]>

The Multiplatform r8a7790 Lager board code is at this point in equally or better state compared to the legacy code.

Quoted 5 lines
Quoted 3 lines

I think it's a bit premature to say this. For example, USBHS DT support
hasn't been merged (the .dts[i] part hasn't even been posted yet IIRC). The USB PHY DT support also hasn't been merged.

Thanks for letting us know. It may be a bit early then.

At this point my feeling is that its better to wait if there are still features in Legacy-C that haven't made it across to multiplatform yet.

Quoted 8 lines
Quoted 1 line

I agree, waiting must be the best option. Thanks!

A general comment about removing board code:

As suggested by Arnd elsewhere, please also submit a patch to remove #ifdef CONFIG_USE_OF from the relevant setup-*.c file when you remove the legacy board code if the setup-*.c will thus always be compiled with ARCH_MULTIPLATFORM which selects CONFIG_USE_OF.

Sure, of course. The main concern from my side was to introduce as few difficulties as ever possible merge-wise. I may have misunderstood things, but I thought having SoC cleanups that depend on Board cleanups in the same merge window may complicate the ARM SoC merge? Because of this a SoC cleanup like suggested above cannot easily depend on a board cleanup like the legacy board code removal patch. So my plan was to first remove the legacy board code in one merge window, and in the second one cleanup the SoC bits.

Quoted 1 line

Please correct me if I'm wrong.

Thanks, that sounds ideal to me.

The main purpose of my previous email was to make a public note about something Arnd had brought to my attention. I agree entirely that we should take care to oder cleanups as you describe.

author maintainer
#10 lore raw
In reply to Magnus Damm

Hi Simon,

Quoted 51 lines · Simon Horman
Quoted 50 lines · Magnus Damm

Hi Simon,

Quoted 29 lines · Simon Horman
Quoted 28 lines · Magnus Damm

Hi Simon,

Quoted 24 lines · Simon Horman
Quoted 15 lines · Magnus Damm

Hi Sergei,

Quoted 11 lines · Sergei Shtylyov

Hello.

Quoted 5 lines · Magnus Damm

From: Magnus Damm <[email protected]>

The Multiplatform r8a7790 Lager board code is at this point in equally or better state compared to the legacy code.

Quoted 5 lines
Quoted 3 lines

I think it's a bit premature to say this. For example, USBHS DT support
hasn't been merged (the .dts[i] part hasn't even been posted yet IIRC). The USB PHY DT support also hasn't been merged.

Thanks for letting us know. It may be a bit early then.

At this point my feeling is that its better to wait if there are still features in Legacy-C that haven't made it across to multiplatform yet.

Quoted 8 lines
Quoted 1 line

I agree, waiting must be the best option. Thanks!

A general comment about removing board code:

As suggested by Arnd elsewhere, please also submit a patch to remove #ifdef CONFIG_USE_OF from the relevant setup-*.c file when you remove the legacy board code if the setup-*.c will thus always be compiled with ARCH_MULTIPLATFORM which selects CONFIG_USE_OF.

Sure, of course. The main concern from my side was to introduce as few difficulties as ever possible merge-wise. I may have misunderstood things, but I thought having SoC cleanups that depend on Board cleanups in the same merge window may complicate the ARM SoC merge? Because of this a SoC cleanup like suggested above cannot easily depend on a board cleanup like the legacy board code removal patch. So my plan was to first remove the legacy board code in one merge window, and in the second one cleanup the SoC bits.

Quoted 7 lines
Quoted 1 line

Please correct me if I'm wrong.

Thanks, that sounds ideal to me.

The main purpose of my previous email was to make a public note about something Arnd had brought to my attention. I agree entirely that we should take care to oder cleanups as you describe.

Gotcha, good to hear that we're on the same page!

/ magnus