Skip to contentSkip to conversation

staging: ozwpan: use kmalloc_array over kmalloc with multiply

PATCH Superseded anicoara 2 participants 2 messages Sep 7, 2014 – Sep 8, 2014 Staging

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

anicoara

author
#0 lore raw

PATCH 4/4 staging: ozwpan: use kmalloc_array over kmalloc with multiply

---
Patch submitted as part of the Eudyptula challenge.

 drivers/staging/ozwpan/ozhcd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/ozwpan/ozhcd.c +1 -1
index ba2168f..4cfe56e 100644
@@ -1315,7 +1315,7 @@ static int oz_build_endpoints_for_config(struct usb_hcd *hcd,
 	if (num_iface) {
 		struct oz_interface *iface;
 
-		iface = kmalloc(num_iface*sizeof(struct oz_interface),
+		iface = kmalloc_array(num_iface, sizeof(struct oz_interface),
 				mem_flags | __GFP_ZERO);
 		if (!iface)
 			return -ENOMEM;

--
2.0.1

#1 lore raw

Your From: line does not contain a real name and does not match your Signed-off-by line, please check your e-mail client settings.

On 2014-09-07 at 20:28:25 +0200, anicoara <[email protected]> wrote:

No changelog text? Please add a short notice, describing why this change is done.

Quoted 12 lines

---
Patch submitted as part of the Eudyptula challenge.

 drivers/staging/ozwpan/ozhcd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/ozwpan/ozhcd.c +0 -0
index ba2168f..4cfe56e 100644

drivers/staging/ozwpan/ozhcd.c static int oz_build_endpoints_for_config(struct usb_hcd *hcd, · line 1319

Quoted 6 lines
drivers/staging/ozwpan/ozhcd.c +1 -1
@@ -1315,7 +1315,7 @@ static int oz_build_endpoints_for_config(struct usb_hcd *hcd,
 	if (num_iface) {
 		struct oz_interface *iface;
 
-		iface = kmalloc(num_iface*sizeof(struct oz_interface),
+		iface = kmalloc_array(num_iface, sizeof(struct oz_interface),
 				mem_flags | __GFP_ZERO);

The line above should be adjusted to match the opening parenthesis.

Quoted 10 lines
drivers/staging/ozwpan/ozhcd.c +0 -1
 		if (!iface)
 			return -ENOMEM;
--

2.0.1

_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel