dvb: si21xx: buffer overflow in si21_writeregs()

PATCH New Dan Carpenter 1 participant 1 message Sep 9, 2014

Subsystems (2)

Media (V4L/DVB) Kernel janitors

lore

Share & tools

lore

Dan Carpenter

author

2014-09-09 12:05 UTC #0 lore raw

PATCH 1/1 dvb: si21xx: buffer overflow in si21_writeregs()

"len" is user controlled and can be up to 255. Anything more than 59 will cause a buffer overflow so we need to add a test for that.

Signed-off-by Dan Carpenter <[email protected]>

drivers/media/dvb-frontends/si21xx.c +3 -0

index 73b47cc..16850e2 100644
@@ -236,6 +236,9 @@ static int si21_writeregs(struct si21xx_state *state, u8 reg1,
 				.len = len + 1
 	};
 
+	if (len > sizeof(buf) - 1)
+		return -EINVAL;
+
 	msg.buf[0] =  reg1;
 	memcpy(msg.buf + 1, data, len);