block: extend BLOCK_IO_ERROR with reason string
PATCH 1/1 block: extend BLOCK_IO_ERROR with reason string
BLOCK_IO_ERROR events are logged by libvirt, which helps with post mortem analysis of guests. However, one information that we miss today is a human readable string describing the cause of the I/O error.
This commit adds that string it to BLOCK_IO_ERROR. Note that this string is a debugging aid for humans, meaning that it should not parsed by applications.
---
This patch applies on top of the following patch:
[PATCH] block: extend BLOCK_IO_ERROR event with nospace indicator
Which has been submitted some time ago and is already applied in the block tree.
block.c | 3 ++- qapi/block-core.json | 7 ++++++- 2 files changed, 8 insertions(+), 2 deletions(-)
block.c +2 -1
@@ -3648,7 +3648,8 @@ static void send_qmp_error_event(BlockDriverState *bs, ac = is_read ?IO_OPERATION_TYPE_READ :IO_OPERATION_TYPE_WRITE ;qapi_event_send_block_io_error (bdrv_get_device_name (bs), ac, action,bdrv_iostatus_is_enabled (bs), - error ==ENOSPC , &error_abort); + error ==ENOSPC ,strerror (error), + &error_abort); }/* This is done by device models because, while the block layer knows
qapi/block-core.json +6 -1
@@ -1593,6 +1593,10 @@ # io-status is present, please see query-block documentation # for more information (since: 2.2) # +# @reason: human readable string describing the error cause. +# (This field is a debugging aid for humans, it should not +# be parsed by applications) (since: 2.2) +# # Note: If action is "stop", a STOP event will eventually follow the # BLOCK_IO_ERROR event #
@@ -1600,7 +1604,8 @@ ## { 'event': 'BLOCK_IO_ERROR', 'data': { 'device': 'str', 'operation': 'IoOperationType', - 'action': 'BlockErrorAction', '*nospace': 'bool' } } + 'action': 'BlockErrorAction', '*nospace': 'bool', + 'reason': 'str' } } ## # @BLOCK_JOB_COMPLETED
Signature · 1 line
1.9.3
Kevin Wolf
AppliedAm 11.09.2014 um 16:25 hat Luiz Capitulino geschrieben:
Quoted 10 lines
BLOCK_IO_ERRORevents are logged by libvirt, which helps with post mortem analysis of guests. However, one information that we miss today is a human readable string describing the cause of the I/O error.This commit adds that string it to
BLOCK_IO_ERROR. Note that this string is a debugging aid for humans, meaning that it should not parsed by applications.Signed-off-by Luiz Capitulino <[email protected]>
Thanks, applied to the block branch.
Kevin
Quoted 11 lines · Luiz Capitulino
BLOCK_IO_ERRORevents are logged by libvirt, which helps with post mortem analysis of guests. However, one information that we miss today is a human readable string describing the cause of the I/O error.This commit adds that string it to
BLOCK_IO_ERROR. Note that this string is a debugging aid for humans, meaning that it should not parsed by applications.Signed-off-by Luiz Capitulino <[email protected]>---
Signature · 2 lines
Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org