Skip to contentSkip to conversation

firmware_class: make sure fw requests contain a name

PATCH In review Kees Cook 2 participants 2 messages Sep 18, 2014 Driver core

lore
Share & tools
lore

Kees Cook

author
#0 lore raw

PATCH 1/1 firmware_class: make sure fw requests contain a name

An empty firmware request name will trigger warnings when building device names. Make sure this is caught earlier and rejected.

The warning was visible via the test_firmware.ko module interface:

echo -ne "\x00" > /sys/devices/virtual/misc/test_firmware/trigger_request

---
 drivers/base/firmware_class.c | 3 +++
 1 file changed, 3 insertions(+)
drivers/base/firmware_class.c +3 -0
index bf424305f3dc..3d785ebb48d3 100644
@@ -1105,6 +1105,9 @@ _request_firmware(const struct firmware **firmware_p, const char *name,
 	if (!firmware_p)
 		return -EINVAL;
 
+	if (!name || name[0] == '\0')
+		return -EINVAL;
+
 	ret = _request_firmware_prepare(&fw, name, device);
 	if (ret <= 0) /* error or already assigned */
 		goto out;
Signature · 6 lines
1.9.1


-- 
Kees Cook
Chrome OS Security
Tested-by on v1 1/1
#1 lore raw
Quoted 10 lines · Kees Cook

An empty firmware request name will trigger warnings when building device names. Make sure this is caught earlier and rejected.

The warning was visible via the test_firmware.ko module interface:

echo -ne "\x00" > /sys/devices/virtual/misc/test_firmware/trigger_request

Works for me!

Thanks,
Sasha