firmware_class: make sure fw requests contain a name
PATCH 1/1 firmware_class: make sure fw requests contain a name
An empty firmware request name will trigger warnings when building device names. Make sure this is caught earlier and rejected.
The warning was visible via the test_firmware.ko module interface:
echo -ne "\x00" > /sys/devices/virtual/misc/test_firmware/trigger_request
Reported-by Sasha Levin <[email protected]>
Signed-off-by Kees Cook <[email protected]>
--- drivers/base/firmware_class.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/base/firmware_class.c +3 -0
@@ -1105,6 +1105,9 @@ _request_firmware(const struct firmware **firmware_p, const char *name,if (!firmware_p)return -EINVAL ; +if (!name || name[0 ] =='\0' ) +return -EINVAL ; + ret =_request_firmware_prepare (&fw, name, device);if (ret <=0 )/* error or already assigned */ goto out;
Signature · 6 lines
1.9.1 -- Kees Cook Chrome OS Security
Quoted 10 lines · Kees Cook
An empty firmware request name will trigger warnings when building device names. Make sure this is caught earlier and rejected.
The warning was visible via the test_firmware.ko module interface:
echo -ne "\x00" >
/sys/devices/virtual/misc/test_firmware/trigger_requestReported-by Sasha Levin <[email protected]>Signed-off-by Kees Cook <[email protected]>
Works for me!
Tested-by Sasha Levin <[email protected]>
Thanks,
Sasha