Skip to contentSkip to conversation

xfstests-bld: specify inode size in inline test scenario conf

PATCH Applied Eric Whitney 2 participants 2 messages Sep 26, 2014 – Sep 27, 2014

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfstests-bld: specify inode size in inline test scenario conf

Some xfstests use test file systems that are smaller than 512 MB, and per the mke2fs.conf default, contain 128 byte inodes. These tests include xfstests generic/015, generic/077, generic/083, and shared/298. All of them fail at mkfs time when run in xfstest-bld's inline test scenario because the inline data feature requires a minimum inode size of 256 bytes.

Fix this problem by specifying an inode size of 256 bytes in the inline conf file. This allows the tester more flexibility than modifying the xfstests themselves.

This change also makes it possible to run generic/027 successfully and in a reasonable amount of time (less than 20 minutes on one x86-64 VM). It also fails silently when mkfs'ing its test file system, but then proceeds to run and reports success erroneously.

---
 kvm-xfstests/test-appliance/files/root/conf/inline | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kvm-xfstests/test-appliance/files/root/conf/inline +1 -1
index 52b0609..9ba088f 100644
@@ -1,7 +1,7 @@
 export FS=ext4
 export TEST_DEV=$VDD
 export TEST_DIR=/vdd
-export MKFS_OPTIONS="-q -O inline_data,metadata_csum,64bit"
+export MKFS_OPTIONS="-q -I 256 -O inline_data,metadata_csum,64bit"
 export EXT_MOUNT_OPTIONS="-o block_validity"
 TESTNAME="Ext4 4k block w/inline"
 
Signature · 1 line
1.9.1
#1 lore raw
Quoted 11 lines · Eric Whitney

Some xfstests use test file systems that are smaller than 512 MB, and per the mke2fs.conf default, contain 128 byte inodes. These tests include xfstests generic/015, generic/077, generic/083, and shared/298. All of them fail at mkfs time when run in xfstest-bld's inline test scenario because the inline data feature requires a minimum inode size of 256 bytes.

Fix this problem by specifying an inode size of 256 bytes in the inline conf file. This allows the tester more flexibility than modifying the xfstests themselves.

Quoted 6 lines

This change also makes it possible to run generic/027 successfully and in a reasonable amount of time (less than 20 minutes on one x86-64 VM). It also fails silently when mkfs'ing its test file system, but then proceeds to run and reports success erroneously.

Applied, thanks.

- Ted