xfstests test xfs/030 failure

Hello,

I'm getting failure for text xfs/030 like:
xfs/030 9s ... - output mismatch (see /var/lib/xfstests/results//xfs/030.out.bad)
--- tests/xfs/030.out 2014-09-30 19:36:53.000000000 +0200
+++ /var/lib/xfstests/results//xfs/030.out.bad 2014-09-30 22:11:38.000000000 +0200
@@ -39,8 +39,8 @@
- traversal finished ...
- moving disconnected inodes to lost+found ...
Phase 7 - verify and correct link counts...
-Note - stripe unit (0) and width (0) fields have been reset.
-Please set with mount -o sunit=<value>,swidth=<value>
+Note - stripe unit (0) and width (0) were copied from a backup superblock.
+Please reset with mount -o sunit=<value>,swidth=<value> if necessary
...
(Run 'diff -u tests/xfs/030.out /var/lib/xfstests/results//xfs/030.out.bad' to see the entire diff)

Now obviously this is because I run xfsprogs 3.2.1 but xfstests have
message from older version of xfsprogs. What is a standard solution for this? If I just replace the messages, then people with older xfsprogs will see failures. So some kind of a filter?

Honza

Quoted 22 lines · Jan Kara

Hello,

I'm getting failure for text xfs/030 like:
xfs/030 9s ... - output mismatch (see /var/lib/xfstests/results//xfs/030.out.bad)
--- tests/xfs/030.out 2014-09-30 19:36:53.000000000 +0200
+++ /var/lib/xfstests/results//xfs/030.out.bad 2014-09-30 22:11:38.000000000 +0200
@@ -39,8 +39,8 @@
- traversal finished ...
- moving disconnected inodes to lost+found ...
Phase 7 - verify and correct link counts...
-Note - stripe unit (0) and width (0) fields have been reset.
-Please set with mount -o sunit=<value>,swidth=<value>
+Note - stripe unit (0) and width (0) were copied from a backup superblock.
+Please reset with mount -o sunit=<value>,swidth=<value> if necessary
...
(Run 'diff -u tests/xfs/030.out /var/lib/xfstests/results//xfs/030.out.bad' to see the entire diff)

Now obviously this is because I run xfsprogs 3.2.1 but xfstests have
message from older version of xfsprogs. What is a standard solution for this? If I just replace the messages, then people with older xfsprogs will see failures. So some kind of a filter?

Quoted 2 lines

Honza

Hi Jan, this should fix it, are you up to date?
(Sorry to all involved for changing this output w/o fixing the tests myself at the same time...)

commit f007c2b465e331317e91b5125e8da04826e57c82

Author: Dave Chinner <[email protected]>
Date:   Mon Sep 8 20:48:59 2014 +1000

filter: update xfs_repair filter for new sunit/swidth warning

New xfs_repair programs have a different sunit/swidth warning that is triggering failures such as:

-Note - stripe unit (0) and width (0) fields have been reset. -Please set with mount -o sunit=<value>,swidth=<value>
+Note - stripe unit (0) and width (0) were copied from a backup superblock. +Please reset with mount -o sunit=<value>,swidth=<value> if necessary

Update the filter to catch both cases and output the old message so tests pass again.

Signed-off-by Dave Chinner <[email protected]>

Reviewed-by Eric Sandeen <[email protected]>

Signed-off-by Dave Chinner <[email protected]>

-Eric