staging: dgap: remove unnecessary if statement for checking NULL

PATCH In review Daeseok Youn 1 participant 1 message Oct 8, 2014 Staging

Share & tools

Daeseok Youn

author

2014-10-08 11:14 UTC #0 lore raw

PATCH 1/3 staging: dgap: remove unnecessary if statement for checking NULL

dgap_release_remap() function is only called after the memory has been remapped so if statement for checking NULL doesn't need.

And also release_mem_region() calls are moved after iounmap() calls.

Signed-off-by Daeseok Youn <[email protected]>

---
 drivers/staging/dgap/dgap.c |   13 ++++---------
 1 files changed, 4 insertions(+), 9 deletions(-)

drivers/staging/dgap/dgap.c +4 -9

index d0be1ce..a48740f 100644
@@ -1013,15 +1013,10 @@ static int dgap_do_remap(struct board_t *brd)
 
 static void dgap_release_remap(struct board_t *brd)
 {
-	if (brd->re_map_membase) {
-		release_mem_region(brd->membase, 0x200000);
-		iounmap(brd->re_map_membase);
-	}
-
-	if (brd->re_map_port) {
-		release_mem_region(brd->membase + PCI_IO_OFFSET, 0x200000);
-		iounmap(brd->re_map_port);
-	}
+	iounmap(brd->re_map_port);
+	iounmap(brd->re_map_membase);
+	release_mem_region(brd->membase + PCI_IO_OFFSET, 0x200000);
+	release_mem_region(brd->membase, 0x200000);
 }
 /*****************************************************************************
 *

Signature · 1 line

1.7.1