staging: rtl8188eu: coding style fixup
PATCH 1/1 staging: rtl8188eu: coding style fixup
checkpatch.pl tiny fix
get rid of 2 warnings and 2 errors for hal/fw.c:
WARNING: braces {} are not necessary for single statement blocks
WARNING: line over 80 characters
ERROR: space required before the open brace '{'
ERROR: space required after that ',' (ctx:VxV)
---
for linux-next 3.17.0
this is an updated version of the patch I've sent yesterday, that one did not provide a clear description
drivers/staging/rtl8188eu/hal/fw.c +5 -5
@@ -154,9 +154,8 @@ static int _rtl88e_fw_free_to_go(struct adapter *adapt)break ; }while (counter++ <POLLING_READY_TIMEOUT_COUNT ); -if (counter >=POLLING_READY_TIMEOUT_COUNT ) { +if (counter >=POLLING_READY_TIMEOUT_COUNT ) goto exit; - } value32 =usb_read32 (adapt,REG_MCUFWDL ); value32 |=MCUFWDL_RDY ;
@@ -193,13 +192,13 @@ int rtl88eu_download_fw(struct adapter *adapt)u32 fwsize;int err; -if (request_firmware (&fw, fw_name, device)){ +if (request_firmware (&fw, fw_name, device)) {dev_err (device,"Firmware %s not available\n" , fw_name);return -ENOENT ; }if (fw->size >FW_8188E_SIZE ) { -dev_err (device,"Firmware size exceed 0x%X. Check it.\n" , +dev_err (device,"Firmware size exceed 0x%X. Check it.\n" ,FW_8188E_SIZE );return -1 ; }
@@ -226,7 +225,8 @@ int rtl88eu_download_fw(struct adapter *adapt)rtl88e_firmware_selfreset (adapt); }_rtl88e_enable_fw_download (adapt, true); -usb_write8 (adapt,REG_MCUFWDL ,usb_read8 (adapt,REG_MCUFWDL ) | FWDL_ChkSum_rpt); +usb_write8 (adapt,REG_MCUFWDL , +usb_read8 (adapt,REG_MCUFWDL ) | FWDL_ChkSum_rpt);_rtl88e_write_fw (adapt, pfwdata, fwsize);_rtl88e_enable_fw_download (adapt, false);
Quoted 7 lines · Igor Bogomazov
checkpatch.pl tiny fix
get rid of 2 warnings and 2 errors forhal/fw.c:WARNING: braces {} are not necessary for single statement blocks
WARNING: line over 80 characters
ERROR: space required before the open brace '{'
ERROR: space required after that ',' (ctx:VxV)
you should usually do only one type of fix in a patch.
Quoted 29 lines
Signed-off-by Igor Bogomazov <[email protected]>Cc Greg Kroah-Hartman <[email protected]>Cc navin patidar <[email protected]>Cc Stephen Rothwell <[email protected]>---
for linux-next 3.17.0this is an updated version of the patch I've sent yesterday, that one did not provide a clear description
drivers/staging/rtl8188eu/hal/fw.c +1
-2@@ -154,9 +154,8 @@ static int _rtl88e_fw_free_to_go(struct adapter *adapt)break ; }while (counter++ <POLLING_READY_TIMEOUT_COUNT ); -if (counter >=POLLING_READY_TIMEOUT_COUNT ) { +if (counter >=POLLING_READY_TIMEOUT_COUNT ) goto exit; - } value32 =usb_read32 (adapt,REG_MCUFWDL ); value32 |=MCUFWDL_RDY ;@@ -193,13 +192,13 @@ int rtl88eu_download_fw(struct adapter *adapt)u32 fwsize;int err;
drivers/staging/rtl8188eu/hal/fw.c int rtl88eu_download_fw(struct adapter *adapt) · line 202
Quoted 10 lines
drivers/staging/rtl8188eu/hal/fw.c +2
-2-if (request_firmware (&fw, fw_name, device)){ +if (request_firmware (&fw, fw_name, device)) {dev_err (device,"Firmware %s not available\n" , fw_name);return -ENOENT ; }if (fw->size >FW_8188E_SIZE ) { -dev_err (device,"Firmware size exceed 0x%X. Check it.\n" , +dev_err (device,"Firmware size exceed 0x%X. Check it.\n" ,FW_8188E_SIZE );
align this with the open parenthesis
drivers/staging/rtl8188eu/hal/fw.c int rtl88eu_download_fw(struct adapter *adapt) · line 229
Quoted 9 lines
drivers/staging/rtl8188eu/hal/fw.c +2
-1return -1 ; }@@ -226,7 +225,8 @@ int rtl88eu_download_fw(struct adapter *adapt)rtl88e_firmware_selfreset (adapt); }_rtl88e_enable_fw_download (adapt, true); -usb_write8 (adapt,REG_MCUFWDL ,usb_read8 (adapt,REG_MCUFWDL ) | FWDL_ChkSum_rpt); +usb_write8 (adapt,REG_MCUFWDL , +usb_read8 (adapt,REG_MCUFWDL ) | FWDL_ChkSum_rpt);
same here also.
check your patch with --strict option of checkpatch
thanks
sudip
Quoted 8 lines
drivers/staging/rtl8188eu/hal/fw.c +0
-1_rtl88e_write_fw (adapt, pfwdata, fwsize);_rtl88e_enable_fw_download (adapt, false); --To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/