Skip to contentSkip to conversation

XFS development tree branch, xfs-misc-fixes-for-3.18-3, updated. v3.16-11826-ga8b1ee8

XFS updates [email protected] 1 participant 1 message Oct 13, 2014

lore
Share & tools
lore

[email protected]

author Reviewed-by Dave Chinner
#0 lore raw

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "XFS development tree".

The branch, xfs-misc-fixes-for-3.18-3 has been updated
a8b1ee8 xfs: fix agno increment in xfs_inumbers() loop

      from  52177937e9ac4573391143065b250403d3a6ae4b (commit)

Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below.

- Log ----------------------------------------------------------------- commit a8b1ee8bafc765ebf029d03c5479a69aebff9693

Author: Eric Sandeen <[email protected]>
Date:   Mon Oct 13 10:21:53 2014 +1100

xfs: fix agno increment in xfs_inumbers() loop

caused a regression in xfs_inumbers, which in turn broke xfsdump, causing incomplete dumps.

The loop in xfs_inumbers() needs to fill the user-supplied buffers, and iterates via xfs_btree_increment, reading new ags as needed.

But the first time through the loop, if xfs_btree_increment() succeeds, we continue, which triggers the ++agno at the bottom of the loop, and we skip to soon to the next ag - without the proper setup under next_ag to read the next ag.

Fix this by removing the agno increment from the loop conditional, and only increment agno if we have actually hit the code under the next_ag: target.

-----------------------------------------------------------------------

Summary of changes:

 fs/xfs/xfs_itable.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

hooks/post-receive

Signature · 6 lines
XFS development tree

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs