net: sched: initialize bstats syncp

PATCH Applied Sabrina Dubroca 3 participants 3 messages Oct 21, 2014 – Oct 22, 2014

Subsystems (3)

Networking Network drivers Traffic control (tc)

lore

Share & tools

lore

Sabrina Dubroca

author

2014-10-21 09:23 UTC #0 lore raw

PATCH 1/1 net: sched: initialize bstats syncp

Use netdev_alloc_pcpu_stats to allocate percpu stats and initialize syncp.

Fixes 22e0f8b9322c "net: sched: make bstats per cpu and estimator RCU safe"

Signed-off-by Sabrina Dubroca <[email protected]>

---
 net/sched/sch_api.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

net/sched/sch_api.c +1 -1

index 2cf61b3e633c..76f402e05bd6 100644
@@ -947,7 +947,7 @@ qdisc_create(struct net_device *dev, struct netdev_queue *dev_queue,
 	if (!ops->init || (err = ops->init(sch, tca[TCA_OPTIONS])) == 0) {
 		if (qdisc_is_percpu_stats(sch)) {
 			sch->cpu_bstats =
-				alloc_percpu(struct gnet_stats_basic_cpu);
+				netdev_alloc_pcpu_stats(struct gnet_stats_basic_cpu);
 			if (!sch->cpu_bstats)
 				goto err_out4;

Signature · 1 line

2.1.2

Cong Wang

Acked-by on v1 1/1

2014-10-21 18:52 UTC #1 lore raw

Quoted 4 lines · Sabrina Dubroca

Use netdev_alloc_pcpu_stats to allocate percpu stats and initialize syncp.
Fixes 22e0f8b9322c "net: sched: make bstats per cpu and estimator RCU safe"
Signed-off-by Sabrina Dubroca <[email protected]>

Acked-by Cong Wang <[email protected]>

David Miller

maintainer Applied

2014-10-22 01:46 UTC #2 lore raw

In reply to Sabrina Dubroca

From: Sabrina Dubroca <[email protected]>
Date: Tue, 21 Oct 2014 11:23:30 +0200

Quoted 4 lines

Use netdev_alloc_pcpu_stats to allocate percpu stats and initialize syncp.
Fixes 22e0f8b9322c "net: sched: make bstats per cpu and estimator RCU safe"
Signed-off-by Sabrina Dubroca <[email protected]>

Applied, thank you.