ocfs2: fix an off-by-one BUG_ON() statement

PATCH New Dan Carpenter 1 participant 1 message Oct 22, 2014

Subsystems (2)

Kernel janitors OCFS2

lore

Share & tools

lore

Dan Carpenter

author

2014-10-22 08:13 UTC #0 lore raw

PATCH 1/1 ocfs2: fix an off-by-one BUG_ON() statement

The ->si_slots[] array is allocated in ocfs2_init_slot_info() it has "->max_slots" number of elements so this test should be >= instead of >.

Signed-off-by Dan Carpenter <[email protected]>

---
Static checker work. Compile tested only.

fs/ocfs2/slot_map.c +1 -1

index a88b2a4..d5493e3 100644
@@ -306,7 +306,7 @@ int ocfs2_slot_to_node_num_locked(struct ocfs2_super *osb, int slot_num,
 	assert_spin_locked(&osb->osb_lock);
 
 	BUG_ON(slot_num < 0);
-	BUG_ON(slot_num > osb->max_slots);
+	BUG_ON(slot_num >= osb->max_slots);
 
 	if (!si->si_slots[slot_num].sl_valid)
 		return -ENOENT;