media: dvb_core: fix an error message

PATCH New Dan Carpenter 1 participant 1 message Oct 29, 2014

Subsystems (2)

Media (V4L/DVB) Kernel janitors

lore

Share & tools

lore

Dan Carpenter

author

2014-10-29 15:47 UTC #0 lore raw

PATCH 1/1 media: dvb_core: fix an error message

The right shift has higher precedence than the mask so the warning doesn't match what the test was checking. Also it's better to use TS_SC instead of magic number 0xC0.

Signed-off-by Dan Carpenter <[email protected]>

drivers/media/dvb-core/dvb_net.c +1 -1

index 059e611..360ef2b 100644
@@ -379,7 +379,7 @@ static void dvb_net_ule( struct net_device *dev, const u8 *buf, size_t buf_len )
 			/* Check TS error conditions: sync_byte, transport_error_indicator, scrambling_control . */
 			if ((ts[0] != TS_SYNC) || (ts[1] & TS_TEI) || ((ts[3] & TS_SC) != 0)) {
 				printk(KERN_WARNING "%lu: Invalid TS cell: SYNC %#x, TEI %u, SC %#x.\n",
-				       priv->ts_count, ts[0], ts[1] & TS_TEI >> 7, ts[3] & 0xC0 >> 6);
+				       priv->ts_count, ts[0], (ts[1] & TS_TEI) >> 7, (ts[3] & TS_SC) >> 6);
 
 				/* Drop partly decoded SNDU, reset state, resync on PUSI. */
 				if (priv->ule_skb) {