iwlwifi: cleanup a mask shift in iwlagn_bt_traffic_is_sco()
PATCH 1/1 iwlwifi: cleanup a mask shift in iwlagn_bt_traffic_is_sco()
The shift operation is higher precedence so the code is wrong and it sets of a static checker warning. But it doesn't affect real life because BT_UART_MSG_FRAME3SCOESCO_POS is zero so the shift is a no-op.
I have re-written it in normal style and with parenthesis as a cleanup and to silence the static checker warning.
Signed-off-by Dan Carpenter <[email protected]>
drivers/net/wireless/iwlwifi/dvm/lib.c +1 -1
@@ -418,7 +418,7 @@ void iwlagn_bt_adjust_rssi_monitor(struct iwl_priv *priv, bool rssi_ena)static bool iwlagn_bt_traffic_is_sco (struct iwl_bt_uart_msg *uart_msg) { -return BT_UART_MSG_FRAME3SCOESCO_MSK & uart_msg->frame3 >> +return (uart_msg->frame3 &BT_UART_MSG_FRAME3SCOESCO_MSK ) >>BT_UART_MSG_FRAME3SCOESCO_POS ; }
Quoted 9 lines · Dan Carpenter
The shift operation is higher precedence so the code is wrong and it sets of a static checker warning. But it doesn't affect real life because
BT_UART_MSG_FRAME3SCOESCO_POSis zero so the shift is a no-op.I have re-written it in normal style and with parenthesis as a cleanup and to silence the static checker warning.
Signed-off-by Dan Carpenter <[email protected]>
In my tree already - I got it from Joe.