Skip to contentSkip to conversation

tcp: Correction to RFC number in comment

PATCH Superseded Sowmini Varadhan 2 participants 3 messages Oct 29, 2014 – Oct 30, 2014

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 tcp: Correction to RFC number in comment

Challenge ACK is described in RFC 5961, fix typo.

---
 net/ipv4/tcp_input.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/ipv4/tcp_input.c +1 -1
index a12b455..d285962 100644
@@ -5028,7 +5028,7 @@ static bool tcp_validate_incoming(struct sock *sk, struct sk_buff *skb,
 	/* step 3: check security and precedence [ignored] */
 
 	/* step 4: Check for a SYN
-	 * RFC 5691 4.2 : Send a challenge ack
+	 * RFC 5961 4.2 : Send a challenge ack
 	 */
 	if (th->syn) {
 syn_challenge:
Signature · 1 line
1.8.4.2
maintainer
#1 lore raw

From: Sowmini Varadhan <[email protected]>
Date: Wed, 29 Oct 2014 15:27:29 -0400

Quoted 3 lines

Challenge ACK is described in RFC 5961, fix typo.

This TCP change has nothing to do with your sunvnet driver changes.

Please do not ever mix unrelated changes like this within a series.

Submit the TCP change on it's own, and then respin the sunvnet driver specific patches separately.

Thanks.

#2 lore raw
Quoted 5 lines · David Miller

Please do not ever mix unrelated changes like this within a series.

Submit the TCP change on it's own, and then respin the sunvnet driver specific patches separately.

Done.

fwiw, I ran into this comment when debugging something in sunvnet, and was quite confused by the rfc 5691 reference :-)

--Sowmini