Skip to contentSkip to conversation

dvb-usb-dvbsky: fix i2c adapter for sp2 device

PATCH In review Nibble Max 2 participants 2 messages Nov 8, 2014 – Nov 9, 2014 Media (V4L/DVB)

lore
Share & tools
lore

Nibble Max

author
#0 lore raw

PATCH 1/1 dvb-usb-dvbsky: fix i2c adapter for sp2 device

It is wrong that sp2 device uses the i2c adapter from m88ds3103 return. sp2 device sits on the same i2c bus with m88ds3103, not behind m88ds3103.

---
 drivers/media/usb/dvb-usb-v2/dvbsky.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/usb/dvb-usb-v2/dvbsky.c +1 -1
index c67a118..8be8447 100644
@@ -479,7 +479,7 @@ static int dvbsky_s960c_attach(struct dvb_usb_adapter *adap)
 	info.addr = 0x40;
 	info.platform_data = &sp2_config;
 	request_module("sp2");
-	client_ci = i2c_new_device(i2c_adapter, &info);
+	client_ci = i2c_new_device(&d->i2c_adap, &info);
 	if (client_ci == NULL || client_ci->dev.driver == NULL) {
 		ret = -ENODEV;
 		goto fail_ci_device;
Signature · 1 line
1.9.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Nibble Max

It is wrong that sp2 device uses the i2c adapter from m88ds3103 return. sp2 device sits on the same i2c bus with m88ds3103, not behind m88ds3103.

Antti

Quoted 19 lines
---
  drivers/media/usb/dvb-usb-v2/dvbsky.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/usb/dvb-usb-v2/dvbsky.c +1 -1
index c67a118..8be8447 100644
@@ -479,7 +479,7 @@ static int dvbsky_s960c_attach(struct dvb_usb_adapter *adap)
  	info.addr = 0x40;
  	info.platform_data = &sp2_config;
  	request_module("sp2");
-	client_ci = i2c_new_device(i2c_adapter, &info);
+	client_ci = i2c_new_device(&d->i2c_adap, &info);
  	if (client_ci == NULL || client_ci->dev.driver == NULL) {
  		ret = -ENODEV;
  		goto fail_ci_device;
Signature · 1 line
http://palosaari.fi/