Skip to contentSkip to conversation

sata_fsl: fix error handling of irq_of_parse_and_map

PATCH In review Dmitry Torokhov 2 participants 2 messages Nov 14, 2014 – Dec 2, 2014 libata

lore
Share & tools
lore

Dmitry Torokhov

author
#0 lore raw

PATCH 1/1 sata_fsl: fix error handling of irq_of_parse_and_map

irq_of_parse_and_map() returns 0 on error (the result is unsigned int), so testing for negative result never works.

Signed-off-by Dmitry Torokhov <[email protected]>

---

Not tested, found by casual code inspection.

 drivers/ata/sata_fsl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ata/sata_fsl.c +1 -1
index 4217415..f9054cd 100644
@@ -1488,7 +1488,7 @@ static int sata_fsl_probe(struct platform_device *ofdev)
 	host_priv->csr_base = csr_base;
 
 	irq = irq_of_parse_and_map(ofdev->dev.of_node, 0);
-	if (irq < 0) {
+	if (!irq) {
 		dev_err(&ofdev->dev, "invalid irq from platform\n");
 		goto error_exit_with_cleanup;
 	}
Signature · 5 lines
2.1.0.rc2.206.gedb03e5


-- 
Dmitry
#1 lore raw
Quoted 4 lines · Dmitry Torokhov

irq_of_parse_and_map() returns 0 on error (the result is unsigned int), so testing for negative result never works.

Signed-off-by Dmitry Torokhov <[email protected]>

Sorry about the delay. Applied to libata/for-3.18-fixes w/ stable cc'd.

Thanks.

Signature · 1 line
tejun