exynos4-is: fix error handling of irq_of_parse_and_map

PATCH New Dmitry Torokhov 1 participant 1 message Nov 14, 2014

Subsystems (2)

Media (V4L/DVB) Arm Samsung Exynos

lore

Share & tools

lore

Dmitry Torokhov

author

2014-11-14 22:09 UTC #0 lore raw

PATCH 1/1 exynos4-is: fix error handling of irq_of_parse_and_map

Return value of irq_of_parse_and_map() is unsigned int, with 0 indicating failure, so testing for negative result never works.

Signed-off-by Dmitry Torokhov <[email protected]>

---

Not tested, found by casual code inspection.

 drivers/media/platform/exynos4-is/fimc-is.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/media/platform/exynos4-is/fimc-is.c +2 -2

index 94c6b47..0fdca86 100644
@@ -814,9 +814,9 @@ static int fimc_is_probe(struct platform_device *pdev)
 		return -ENOMEM;
 
 	is->irq = irq_of_parse_and_map(dev->of_node, 0);
-	if (is->irq < 0) {
+	if (!is->irq) {
 		dev_err(dev, "no irq found\n");
-		return is->irq;
+		return -EINVAL;
 	}
 
 	ret = fimc_is_get_clocks(is);

Signature · 5 lines

2.1.0.rc2.206.gedb03e5


-- 
Dmitry