usb: gadget: udc: clean up a printk

PATCH New Dan Carpenter 1 participant 1 message Nov 25, 2014

Subsystems (3)

USB Kernel janitors Broadcom bdc driver

lore

Share & tools

lore

Dan Carpenter

author

2014-11-25 15:55 UTC #0 lore raw

PATCH 1/2 usb: gadget: udc: clean up a printk

We already know what "value" is, so there is no need to check. It puzzles static checkers to have the unneeded condition.

Signed-off-by Dan Carpenter <[email protected]>

drivers/usb/gadget/udc/bdc/bdc_ep.c +4 -4

index 15da5b1..2f4ac6e 100644
@@ -880,8 +880,8 @@ static int ep_set_halt(struct bdc_ep *ep, u32 value)
 
 		ret = bdc_ep_set_stall(bdc, ep->ep_num);
 		if (ret)
-			dev_err(bdc->dev, "failed to %s STALL on %s\n",
-				value ? "set" : "clear", ep->name);
+			dev_err(bdc->dev, "failed to set STALL on %s\n",
+				ep->name);
 		else
 			ep->flags |= BDC_EP_STALL;
 	} else {

@@ -889,8 +889,8 @@ static int ep_set_halt(struct bdc_ep *ep, u32 value)
 		dev_dbg(bdc->dev, "Before Clear\n");
 		ret = bdc_ep_clear_stall(bdc, ep->ep_num);
 		if (ret)
-			dev_err(bdc->dev, "failed to %s STALL on %s\n",
-				value ? "set" : "clear", ep->name);
+			dev_err(bdc->dev, "failed to clear STALL on %s\n",
+				ep->name);
 		else
 			ep->flags &= ~BDC_EP_STALL;
 		dev_dbg(bdc->dev, "After  Clear\n");