USB: adutux: NULL dereferences on disconnect

PATCH New Dan Carpenter 1 participant 1 message Nov 26, 2014

Subsystems (2)

USB Kernel janitors

lore

Share & tools

lore

Dan Carpenter

author

2014-11-26 14:06 UTC #0 lore raw

PATCH 1/1 USB: adutux: NULL dereferences on disconnect

Both "dev->udev" and "interface->dev" are NULL. These printks are not very interesting so I just deleted them.

Fixes 03270634e242 ('USB: Add ADU support for Ontrak ADU devices')

Signed-off-by Dan Carpenter <[email protected]>

drivers/usb/misc/adutux.c +0 -5

index 493c7f2..3071c0e 100644
@@ -814,15 +814,10 @@ static void adu_disconnect(struct usb_interface *interface)
 	usb_set_intfdata(interface, NULL);
 
 	/* if the device is not opened, then we clean up right now */
-	dev_dbg(&dev->udev->dev, "%s : open count %d\n",
-		__func__, dev->open_count);
 	if (!dev->open_count)
 		adu_delete(dev);
 
 	mutex_unlock(&adutux_mutex);
-
-	dev_info(&interface->dev, "ADU device adutux%d now disconnected\n",
-		 (minor - ADU_MINOR_BASE));
 }
 
 /* usb specific object needed to register this driver with the usb subsystem */