Unmatching rule
Hello,
I was doing some conversion using coccinelle using the attached script
and I'm wondering why the rule unreg2 doesn't match anywhere in linux kernel in drivers/media/dvb-core/dvbdev.c. Can someone explain to me what am I doing wrong? Thanks!
Honza
Signature · 86 lines
Jan Kara <[email protected]> SUSE Labs, CR -------------- next part -------------- @decl@ identifier x; @@ -static struct cdev x; @initadd@ identifier decl.x; expression fops; identifier ret; expression d; expression count; statement stmt; @@ - cdev_init(&x, fops); ( - ret = cdev_add(&x, d, count); - if (<+...ret...+>) stmt | - if (<+...cdev_add(&x, d, count)...+>) stmt ) @creationdyn@ identifier d; identifier ret; identifier major; expression initadd.fops; expression name; expression initadd.count; expression first_minor; @@ - dev_t d; ... - ret = alloc_chrdev_region(&d, first_minor, count, name); + ret = __register_chrdev(0, first_minor, count, name, fops); ... - major = MAJOR(d); + major = ret; @creationstat@ identifier d; identifier ret; expression major; expression initadd.fops; expression name; expression initadd.count; expression first_minor; statement stmt; @@ - dev_t d = MKDEV(major, first_minor); ... ( - ret = register_chrdev_region(d, count, name); + ret = __register_chrdev(major, first_minor, count, name, fops); | - if (<+...ret = register_chrdev_region(d, count, name)...+>) stmt + ret = __register_chrdev(major, first_minor, count, name, fops); + if (ret) stmt ) @deletion@ identifier decl.x; @@ - cdev_del(&x); @unreg@ identifier d; expression count; expression major, minor; expression creationstat.name; @@ - dev_t d = MKDEV(major, minor); ... - unregister_chrdev_region(d, count); + __unregister_chrdev(major, minor, count, name); @unreg2@ expression d; expression count; expression creationstat.major, creationstat.first_minor; expression creationstat.name; @@ - unregister_chrdev_region(d, count); + __unregister_chrdev(major, first_minor, count, name);
Quoted 6 lines · Jan Kara
Hello,
I was doing some conversion using coccinelle using the attached script
and I'm wondering why the rule unreg2 doesn't match anywhere in linux kernel indrivers/media/dvb-core/dvbdev.c. Can someone explain to me what am I doing wrong? Thanks!
Ah, I figured it out a moment after I sent this email. The prerequisite
rule wasn't matching and I missed that when looking at the generated diff.
Honza
Quoted 87 lines
Signature · 16 lines
Jan Kara <[email protected]> SUSE Labs, CR @decl@ identifier x; @@ -static struct cdev x; @initadd@ identifier decl.x; expression fops; identifier ret; expression d; expression count; statement stmt; @@(quoted diff) +0
-1- cdev_init(&x, fops);(
(quoted diff) +0
-2- ret = cdev_add(&x, d, count); - if (<+...ret...+>) stmt|
(quoted diff) +0
-1- if (<+...cdev_add(&x, d, count)...+>) stmt)
@creationdyn@
identifier d;
identifier ret;
identifier major;
expression initadd.fops;
expression name;
expression initadd.count;
expressionfirst_minor;
@@(quoted diff) +2
-3- dev_t d; - ret = alloc_chrdev_region(&d, first_minor, count, name); + ret = __register_chrdev(0, first_minor, count, name, fops); - major = MAJOR(d); + major = ret;@creationstat@
identifier d;
identifier ret;
expression major;
expression initadd.fops;
expression name;
expression initadd.count;
expressionfirst_minor;
statement stmt;
@@(quoted diff) +0
-1- dev_t d = MKDEV(major, first_minor);(
(quoted diff) +1
-1- ret = register_chrdev_region(d, count, name); + ret = __register_chrdev(major, first_minor, count, name, fops);|
(quoted diff) +2
-1- if (<+...ret = register_chrdev_region(d, count, name)...+>) stmt + ret = __register_chrdev(major, first_minor, count, name, fops); + if (ret) stmt)
@deletion@
identifier decl.x;
@@(quoted diff) +0
-1- cdev_del(&x);@unreg@
identifier d;
expression count;
expression major, minor;
expression creationstat.name;
@@(quoted diff) +1
-2- dev_t d = MKDEV(major, minor); - unregister_chrdev_region(d, count); + __unregister_chrdev(major, minor, count, name);@unreg2@
expression d;
expression count;
expression creationstat.major, creationstat.first_minor; expression creationstat.name;
@@(quoted diff) +1
-1- unregister_chrdev_region(d, count); + __unregister_chrdev(major, first_minor, count, name);
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR
Quoted 9 lines · Jan Kara
Quoted 6 lines · Jan Kara
Hello,
I was doing some conversion using coccinelle using the attached script
and I'm wondering why the rule unreg2 doesn't match anywhere in linux kernel indrivers/media/dvb-core/dvbdev.c. Can someone explain to me what am I doing wrong? Thanks!Ah, I figured it out a moment after I sent this email. The prerequisite
rule wasn't matching and I missed that when looking at the generated diff.
Good to have problems solved so quickly :)
julia
Quoted 99 lines
Honza
Quoted 87 lines
Signature · 16 lines
Jan Kara <[email protected]> SUSE Labs, CR @decl@ identifier x; @@ -static struct cdev x; @initadd@ identifier decl.x; expression fops; identifier ret; expression d; expression count; statement stmt; @@(quoted diff) +0
-1- cdev_init(&x, fops);(
(quoted diff) +0
-2- ret = cdev_add(&x, d, count); - if (<+...ret...+>) stmt|
(quoted diff) +0
-1- if (<+...cdev_add(&x, d, count)...+>) stmt)
@creationdyn@
identifier d;
identifier ret;
identifier major;
expression initadd.fops;
expression name;
expression initadd.count;
expressionfirst_minor;
@@(quoted diff) +2
-3- dev_t d; - ret = alloc_chrdev_region(&d, first_minor, count, name); + ret = __register_chrdev(0, first_minor, count, name, fops); - major = MAJOR(d); + major = ret;@creationstat@
identifier d;
identifier ret;
expression major;
expression initadd.fops;
expression name;
expression initadd.count;
expressionfirst_minor;
statement stmt;
@@(quoted diff) +0
-1- dev_t d = MKDEV(major, first_minor);(
(quoted diff) +1
-1- ret = register_chrdev_region(d, count, name); + ret = __register_chrdev(major, first_minor, count, name, fops);|
(quoted diff) +2
-1- if (<+...ret = register_chrdev_region(d, count, name)...+>) stmt + ret = __register_chrdev(major, first_minor, count, name, fops); + if (ret) stmt)
@deletion@
identifier decl.x;
@@(quoted diff) +0
-1- cdev_del(&x);@unreg@
identifier d;
expression count;
expression major, minor;
expression creationstat.name;
@@(quoted diff) +1
-2- dev_t d = MKDEV(major, minor); - unregister_chrdev_region(d, count); + __unregister_chrdev(major, minor, count, name);@unreg2@
expression d;
expression count;
expression creationstat.major, creationstat.first_minor; expression creationstat.name;
@@(quoted diff) +1
-1- unregister_chrdev_region(d, count); + __unregister_chrdev(major, first_minor, count, name);Signature · 6 lines
Jan Kara <[email protected]> SUSE Labs, CR _______________________________________________ Cocci mailing list Cocci at systeme.lip6.fr https://systeme.lip6.fr/mailman/listinfo/cocci