Skip to contentSkip to conversation

Staging: line6: fix parentheses around macro in usbdefs.h

PATCH In review Sam van Kampen 2 participants 3 messages Dec 3, 2014 Staging

lore
Share & tools
lore

Sam van Kampen

author
#0 lore raw

PATCH 1/1 Staging: line6: fix parentheses around macro in usbdefs.h

Quoted 1 line

From a9deb1763d3f23a3b005e63fdc896c6d903097d1 Mon Sep 17 00:00:00 2001

From: Sam van Kampen <[email protected]>
Date: Wed, 3 Dec 2014 09:05:51 +0100
Subject: [PATCH] Staging: line6: fix parentheses around macro in usbdefs.h

This patch fixes the error "Macros with complex values should be enclosed in parentheses", as reported by checkpatch.pl.

Signed-off-by Sam van Kampen <[email protected]>
---
 drivers/staging/line6/usbdefs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/line6/usbdefs.h +1 -1
index 2d1cc47..48958b5 100644
@@ -40,7 +40,7 @@
 #define LINE6_DEVID_TONEPORT_UX2  0x4142
 #define LINE6_DEVID_VARIAX        0x534d
 
-#define LINE6_BIT(x) LINE6_BIT_ ## x = 1 << LINE6_INDEX_ ## x
+#define LINE6_BIT(x) (LINE6_BIT_ ## x = 1 << LINE6_INDEX_ ## x)
 
 enum {
 	LINE6_INDEX_BASSPODXT,
Signature · 1 line
2.0.4
maintainer
#1 lore raw
Quoted 4 lines · Sam van Kampen
Quoted 1 line

From a9deb1763d3f23a3b005e63fdc896c6d903097d1 Mon Sep 17 00:00:00 2001

From: Sam van Kampen <[email protected]>
Date: Wed, 3 Dec 2014 09:05:51 +0100
Subject: [PATCH] Staging: line6: fix parentheses around macro in usbdefs.h

Why is this mess here?

Quoted 7 lines

This patch fixes the error "Macros with complex values should be enclosed in parentheses", as reported by checkpatch.pl.

Signed-off-by Sam van Kampen <[email protected]>
---
 drivers/staging/line6/usbdefs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Any reason you didn't use scripts/get_maintainer.pl to determine who to send the patch to? Please do that and resend.

thanks,

greg k-h

author
#2 lore raw
Quoted 7 lines · Greg Kroah-Hartman
Quoted 4 lines · Sam van Kampen
Quoted 1 line

From a9deb1763d3f23a3b005e63fdc896c6d903097d1 Mon Sep 17 00:00:00 2001

From: Sam van Kampen <[email protected]>
Date: Wed, 3 Dec 2014 09:05:51 +0100
Subject: [PATCH] Staging: line6: fix parentheses around macro in usbdefs.h

Why is this mess here?

Sorry, the mess was auto-generated by git format-patch. I had seen it before on the mailing list and therefore didn't question it.

Quoted 11 lines
Quoted 8 lines

This patch fixes the error "Macros with complex values should be enclosed in parentheses", as reported by checkpatch.pl.

Signed-off-by Sam van Kampen <[email protected]>
---
 drivers/staging/line6/usbdefs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Any reason you didn't use scripts/get_maintainer.pl to determine who to send the patch to? Please do that and resend.

I wasn't sure whether I should send the patch to everyone on that list, so I merely sent it to you and linux-kernel (missing the list for the staging subsystem). I'll resend it, without the mess and with the correct recipients.

Thanks,
Sam