Skip to contentSkip to conversation

mpt3sas: issue_reset is uninitialized

PATCH Superseded Dan Carpenter 3 participants 4 messages Dec 3, 2014 – Dec 30, 2014

Subsystems (3)
SCSI Kernel janitors LSI Logic MPT fusion drivers (FC/SAS/SPI)
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 mpt3sas: issue_reset is uninitialized

We never set "issue_reset" to zero.

Signed-off-by Dan Carpenter <[email protected]>
drivers/scsi/mpt3sas/mpt3sas_base.c +2 -2
index 1560115..a6d471a 100644
@@ -3419,7 +3419,7 @@ mpt3sas_base_sas_iounit_control(struct MPT3SAS_ADAPTER *ioc,
 	u16 smid;
 	u32 ioc_state;
 	unsigned long timeleft;
-	u8 issue_reset;
+	bool issue_reset = 0;
 	int rc;
 	void *request;
 	u16 wait_state_count;

@@ -3523,7 +3523,7 @@ mpt3sas_base_scsi_enclosure_processor(struct MPT3SAS_ADAPTER *ioc,
 	u16 smid;
 	u32 ioc_state;
 	unsigned long timeleft;
-	u8 issue_reset;
+	bool issue_reset = 0;
 	int rc;
 	void *request;
 	u16 wait_state_count;
author
#1 lore raw

PATCH v2 1/1 mpt3sas: issue_reset is uninitialized

The "issue_reset" can be used uninitialized. It should be set to false at the start.

Also I cleaned up the types a little by using bool.

Signed-off-by Dan Carpenter <[email protected]>

---
v2: style fix. use true/false instead of 1/0.

drivers/scsi/mpt3sas/mpt3sas_base.c +4 -4
index 1560115..b9c2739 100644
@@ -3419,7 +3419,7 @@ mpt3sas_base_sas_iounit_control(struct MPT3SAS_ADAPTER *ioc,
 	u16 smid;
 	u32 ioc_state;
 	unsigned long timeleft;
-	u8 issue_reset;
+	bool issue_reset = false;
 	int rc;
 	void *request;
 	u16 wait_state_count;

@@ -3483,7 +3483,7 @@ mpt3sas_base_sas_iounit_control(struct MPT3SAS_ADAPTER *ioc,
 		_debug_dump_mf(mpi_request,
 		    sizeof(Mpi2SasIoUnitControlRequest_t)/4);
 		if (!(ioc->base_cmds.status & MPT3_CMD_RESET))
-			issue_reset = 1;
+			issue_reset = true;
 		goto issue_host_reset;
 	}
 	if (ioc->base_cmds.status & MPT3_CMD_REPLY_VALID)

@@ -3523,7 +3523,7 @@ mpt3sas_base_scsi_enclosure_processor(struct MPT3SAS_ADAPTER *ioc,
 	u16 smid;
 	u32 ioc_state;
 	unsigned long timeleft;
-	u8 issue_reset;
+	bool issue_reset = false;
 	int rc;
 	void *request;
 	u16 wait_state_count;

@@ -3581,7 +3581,7 @@ mpt3sas_base_scsi_enclosure_processor(struct MPT3SAS_ADAPTER *ioc,
 		_debug_dump_mf(mpi_request,
 		    sizeof(Mpi2SepRequest_t)/4);
 		if (!(ioc->base_cmds.status & MPT3_CMD_RESET))
-			issue_reset = 1;
+			issue_reset = false;
 		goto issue_host_reset;
 	}
 	if (ioc->base_cmds.status & MPT3_CMD_REPLY_VALID)
#2 lore raw

This patch seems to be good. Please consider this patch as Acked-by:
"Sreekanth Reddy" <[email protected]>

Regards,
Sreekanth

Quoted 49 lines · Dan Carpenter

The "issue_reset" can be used uninitialized. It should be set to false at the start.

Also I cleaned up the types a little by using bool.

Signed-off-by Dan Carpenter <[email protected]>

---
v2: style fix. use true/false instead of 1/0.

drivers/scsi/mpt3sas/mpt3sas_base.c +4 -4
index 1560115..b9c2739 100644
@@ -3419,7 +3419,7 @@ mpt3sas_base_sas_iounit_control(struct MPT3SAS_ADAPTER *ioc,
        u16 smid;
        u32 ioc_state;
        unsigned long timeleft;
-       u8 issue_reset;
+       bool issue_reset = false;
        int rc;
        void *request;
        u16 wait_state_count;

@@ -3483,7 +3483,7 @@ mpt3sas_base_sas_iounit_control(struct MPT3SAS_ADAPTER *ioc,
                _debug_dump_mf(mpi_request,
                    sizeof(Mpi2SasIoUnitControlRequest_t)/4);
                if (!(ioc->base_cmds.status & MPT3_CMD_RESET))
-                       issue_reset = 1;
+                       issue_reset = true;
                goto issue_host_reset;
        }
        if (ioc->base_cmds.status & MPT3_CMD_REPLY_VALID)

@@ -3523,7 +3523,7 @@ mpt3sas_base_scsi_enclosure_processor(struct MPT3SAS_ADAPTER *ioc,
        u16 smid;
        u32 ioc_state;
        unsigned long timeleft;
-       u8 issue_reset;
+       bool issue_reset = false;
        int rc;
        void *request;
        u16 wait_state_count;

@@ -3581,7 +3581,7 @@ mpt3sas_base_scsi_enclosure_processor(struct MPT3SAS_ADAPTER *ioc,
                _debug_dump_mf(mpi_request,
                    sizeof(Mpi2SepRequest_t)/4);
                if (!(ioc->base_cmds.status & MPT3_CMD_RESET))
-                       issue_reset = 1;
+                       issue_reset = false;
                goto issue_host_reset;
        }
        if (ioc->base_cmds.status & MPT3_CMD_REPLY_VALID)