Skip to contentSkip to conversation

mpt2sas: issue reset is never uninitialized

PATCH Applied Dan Carpenter 3 participants 3 messages Dec 4, 2014 – Dec 30, 2014

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 mpt2sas: issue reset is never uninitialized

The "issue_reset" variable can be used uninitialized. It should be set to false at the start.

Also I cleaned up the types by using bool.

---
v2: style fix

drivers/scsi/mpt2sas/mpt2sas_base.c +4 -4
index 58e4521..3fb01d1 100644
@@ -3236,7 +3236,7 @@ mpt2sas_base_sas_iounit_control(struct MPT2SAS_ADAPTER *ioc,
 	u16 smid;
 	u32 ioc_state;
 	unsigned long timeleft;
-	u8 issue_reset;
+	bool issue_reset = false;
 	int rc;
 	void *request;
 	u16 wait_state_count;
@@ -3300,7 +3300,7 @@ mpt2sas_base_sas_iounit_control(struct MPT2SAS_ADAPTER *ioc,
 		_debug_dump_mf(mpi_request,
 		    sizeof(Mpi2SasIoUnitControlRequest_t)/4);
 		if (!(ioc->base_cmds.status & MPT2_CMD_RESET))
-			issue_reset = 1;
+			issue_reset = true;
 		goto issue_host_reset;
 	}
 	if (ioc->base_cmds.status & MPT2_CMD_REPLY_VALID)
@@ -3341,7 +3341,7 @@ mpt2sas_base_scsi_enclosure_processor(struct MPT2SAS_ADAPTER *ioc,
 	u16 smid;
 	u32 ioc_state;
 	unsigned long timeleft;
-	u8 issue_reset;
+	bool issue_reset = false;
 	int rc;
 	void *request;
 	u16 wait_state_count;
@@ -3398,7 +3398,7 @@ mpt2sas_base_scsi_enclosure_processor(struct MPT2SAS_ADAPTER *ioc,
 		_debug_dump_mf(mpi_request,
 		    sizeof(Mpi2SepRequest_t)/4);
 		if (!(ioc->base_cmds.status & MPT2_CMD_RESET))
-			issue_reset = 1;
+			issue_reset = true;
 		goto issue_host_reset;
 	}
 	if (ioc->base_cmds.status & MPT2_CMD_REPLY_VALID)
#1 lore raw

This patch seems to be good. Please consider this patch as Acked-by:
"Sreekanth Reddy" <[email protected]>

Regards,
Sreekanth

Quoted 49 lines · Dan Carpenter

The "issue_reset" variable can be used uninitialized. It should be set to false at the start.

Also I cleaned up the types by using bool.

---
v2: style fix

drivers/scsi/mpt2sas/mpt2sas_base.c +4 -4
index 58e4521..3fb01d1 100644
@@ -3236,7 +3236,7 @@ mpt2sas_base_sas_iounit_control(struct MPT2SAS_ADAPTER *ioc,
        u16 smid;
        u32 ioc_state;
        unsigned long timeleft;
-       u8 issue_reset;
+       bool issue_reset = false;
        int rc;
        void *request;
        u16 wait_state_count;
@@ -3300,7 +3300,7 @@ mpt2sas_base_sas_iounit_control(struct MPT2SAS_ADAPTER *ioc,
                _debug_dump_mf(mpi_request,
                    sizeof(Mpi2SasIoUnitControlRequest_t)/4);
                if (!(ioc->base_cmds.status & MPT2_CMD_RESET))
-                       issue_reset = 1;
+                       issue_reset = true;
                goto issue_host_reset;
        }
        if (ioc->base_cmds.status & MPT2_CMD_REPLY_VALID)
@@ -3341,7 +3341,7 @@ mpt2sas_base_scsi_enclosure_processor(struct MPT2SAS_ADAPTER *ioc,
        u16 smid;
        u32 ioc_state;
        unsigned long timeleft;
-       u8 issue_reset;
+       bool issue_reset = false;
        int rc;
        void *request;
        u16 wait_state_count;
@@ -3398,7 +3398,7 @@ mpt2sas_base_scsi_enclosure_processor(struct MPT2SAS_ADAPTER *ioc,
                _debug_dump_mf(mpi_request,
                    sizeof(Mpi2SepRequest_t)/4);
                if (!(ioc->base_cmds.status & MPT2_CMD_RESET))
-                       issue_reset = 1;
+                       issue_reset = true;
                goto issue_host_reset;
        }
        if (ioc->base_cmds.status & MPT2_CMD_REPLY_VALID)