Skip to contentSkip to conversation

nokia_h4p on 3.16+

DISCUSSION Pavel Machek 2 participants 4 messages Dec 8, 2014

lore
Share & tools
lore
#0 lore raw

Hi!

It seems commit:

commit bd5dc09f557547399cd44d0a1224df7ff64e4a6b

Author: Felipe Balbi <[email protected]>
Date:   Wed Apr 23 09:58:28 2014 -0500

serial: fix UART_IIR_ID

UART IRQ Identification bitfield is 3
bits long (bits 3:1) but current mask only
masks 2 bits. Fix it.

breaks bluetooth driver on n900. (drivers/staging/nokia_h4p).

Pali, you may want to revert the patch.

That is good news, because reverting it on 3.18-rcX brings h4p back, too (and as machine boots on nfsroot, debugging should be possible.)

Best regards,
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#1 lore raw
Quoted 19 lines · On Monday 08 December 2014 21:47:35 Pavel Machek wrote:

Hi!

It seems commit:

commit bd5dc09f557547399cd44d0a1224df7ff64e4a6b

Author: Felipe Balbi <[email protected]>
Date:   Wed Apr 23 09:58:28 2014 -0500

serial: fix UART_IIR_ID

UART IRQ Identification bitfield is 3
bits long (bits 3:1) but current mask only
masks 2 bits. Fix it.

breaks bluetooth driver on n900. (drivers/staging/nokia_h4p).

Quoted 8 lines

Pali, you may want to revert the patch.

That is good news, because reverting it on 3.18-rcX brings h4p back, too (and as machine boots on nfsroot, debugging should be possible.)

Best regards,
Pavel

Hi! this is good news.

CCing new freemangordon's @gmail address.

Signature · 9 lines
Pali Roh?r
pali.rohar at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141208/0f5d40aa/attachment.sig>
#2 lore raw
In reply to Pavel Machek
Quoted 19 lines · On Monday 08 December 2014 21:47:35 Pavel Machek wrote:

Hi!

It seems commit:

commit bd5dc09f557547399cd44d0a1224df7ff64e4a6b

Author: Felipe Balbi <[email protected]>
Date:   Wed Apr 23 09:58:28 2014 -0500

serial: fix UART_IIR_ID

UART IRQ Identification bitfield is 3
bits long (bits 3:1) but current mask only
masks 2 bits. Fix it.

breaks bluetooth driver on n900. (drivers/staging/nokia_h4p).

Quoted 8 lines

Pali, you may want to revert the patch.

That is good news, because reverting it on 3.18-rcX brings h4p back, too (and as machine boots on nfsroot, debugging should be possible.)

Best regards,
Pavel

Reverted in linux-n900 git tree in v3.18-rc6-n900 branch.

Signature · 9 lines
Pali Roh?r
pali.rohar at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141208/688fd333/attachment-0001.sig>
#3 lore raw
In reply to Pavel Machek
Quoted 19 lines · On Monday 08 December 2014 21:47:35 Pavel Machek wrote:

Hi!

It seems commit:

commit bd5dc09f557547399cd44d0a1224df7ff64e4a6b

Author: Felipe Balbi <[email protected]>
Date:   Wed Apr 23 09:58:28 2014 -0500

serial: fix UART_IIR_ID

UART IRQ Identification bitfield is 3
bits long (bits 3:1) but current mask only
masks 2 bits. Fix it.

breaks bluetooth driver on n900. (drivers/staging/nokia_h4p).

Quoted 8 lines

Pali, you may want to revert the patch.

That is good news, because reverting it on 3.18-rcX brings h4p back, too (and as machine boots on nfsroot, debugging should be possible.)

Best regards,
Pavel

Pavel, maybe there is some unhandled iir value in function static irqreturn_t hci_h4p_interrupt(int irq, void *data) which cause that driver is not working?

Signature · 9 lines
Pali Roh?r
pali.rohar at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20141208/9712e5a3/attachment.sig>