NFS: a couple off by ones

PATCH New Dan Carpenter 1 participant 1 message Dec 16, 2014

Subsystems (3)

Kernel janitors NFS client NFS server

lore

Share & tools

lore

Dan Carpenter

author

2014-12-16 23:52 UTC #0 lore raw

PATCH 1/1 NFS: a couple off by ones

These tests are off by one because if len = sizeof(nfs_export_path) then we have truncated the name.

Signed-off-by Dan Carpenter <[email protected]>

fs/nfs/nfsroot.c +2 -2

index cd3c910..9bc9f04 100644
@@ -261,11 +261,11 @@ static int __init root_nfs_data(char *cmdline)
 	 */
 	len = snprintf(nfs_export_path, sizeof(nfs_export_path),
 				tmp, utsname()->nodename);
-	if (len > (int)sizeof(nfs_export_path))
+	if (len >= (int)sizeof(nfs_export_path))
 		goto out_devnametoolong;
 	len = snprintf(nfs_root_device, sizeof(nfs_root_device),
 				"%pI4:%s", &servaddr, nfs_export_path);
-	if (len > (int)sizeof(nfs_root_device))
+	if (len >= (int)sizeof(nfs_root_device))
 		goto out_devnametoolong;
 
 	retval = 0;