Skip to contentSkip to conversation

package/snappy: add dependency on host-pkgconf

PATCH New Steve James 2 participants 2 messages Dec 17, 2014 – Dec 18, 2014

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 package/snappy: add dependency on host-pkgconf

Snappy doesn't configure without host pkg-config, causing this totally unhelpful diagnostic from autoconf:

configure.ac:42: error: possibly undefined macro: AC_DEFINE
If this token and others are legitimate, please use m4_pattern_allow. See the Autoconf documentation.
configure.ac:44: error: possibly undefined macro: AC_MSG_FAILURE

So add host-pkgconf to the package's DEPENDENCIES list.

---
Changes v1 -> v2:
- Reorganised this commit comment only; no change to the patch itself

 package/snappy/snappy.mk |    1 +
 1 file changed, 1 insertion(+)
package/snappy/snappy.mk +1 -0
index fd89325..6bda7ce 100644
@@ -10,6 +10,7 @@ SNAPPY_LICENSE = BSD-3c
 SNAPPY_LICENSE_FILES = COPYING
 # from git
 SNAPPY_AUTORECONF = YES
+SNAPPY_DEPENDENCIES = host-pkgconf
 SNAPPY_INSTALL_STAGING = YES
 
 $(eval $(autotools-package))
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH v2 1/1 package/snappy: add dependency on host-pkgconf

Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Steve" == Steve James <[email protected]> writes:

Snappy doesn't configure without host pkg-config, causing this totally unhelpful diagnostic from autoconf:

configure.ac:42: error: possibly undefined macro: AC_DEFINE
If this token and others are legitimate, please use m4_pattern_allow. See the Autoconf documentation.
configure.ac:44: error: possibly undefined macro: AC_MSG_FAILURE

Quoted 8 lines

So add host-pkgconf to the package's DEPENDENCIES list.

---
Changes v1 -> v2:
- Reorganised this commit comment only; no change to the patch itself

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard