Skip to contentSkip to conversation

how to debug missing match?

Cocci Wolfram Sang 2 participants 6 messages Dec 21, 2014 Arm Samsung Exynos

lore
Share & tools
lore
#0 lore raw

Hi

with linux kernel v3.18-rc1 and spatch version 1.0.0-rc22 with Python support and with PCRE support from Debian:

~/Kernel/linux$ spatch -D report --sp-file scripts/coccinelle/api/platform_no_drv_owner.cocci arch/arm/mach-exynos/*.c

produces:

arch/arm/mach-exynos/pmu.c:994:3-8: No need to set .owner here. The core will do it.

tmp/cocci-output-25796-7e6ab9-pmu.c renamed from arm/mach-exynos/pmu.c +0 -1
diff = 
@@ -991,7 +991,6 @@ static int exynos_pmu_probe(struct platf
 static struct platform_driver exynos_pmu_driver = {
 	.driver  = {
 		.name   = "exynos-pmu",
-		.owner	= THIS_MODULE,
 		.of_match_table = exynos_pmu_of_device_ids,
 	},
 	.probe = exynos_pmu_probe,

But:

~/Kernel/linux$ spatch -D report --sp-file scripts/coccinelle/api/platform_no_drv_owner.cocci drivers/macintosh/*.c

does not result in anything although three drivers should match IMO with the same pattern as the pmu driver above. Both use platform_driver_register() and both have the .owner field set.

drivers/macintosh/windfarm_pm112.c
drivers/macintosh/windfarm_pm72.c
drivers/macintosh/windfarm_rm31.c

How can I debug why the match does not occur?

Thanks,

Wolfram

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://systeme.lip6.fr/pipermail/cocci/attachments/20141221/7b223621/attachment.asc>

#1 lore raw
Quoted 10 lines

does not result in anything although three drivers should match IMO with the same pattern as the pmu driver above. Both use platform_driver_register() and both have the .owner field set.

drivers/macintosh/windfarm_pm112.c
drivers/macintosh/windfarm_pm72.c
drivers/macintosh/windfarm_rm31.c

How can I debug why the match does not occur?

So, I found "--verbose-parsing" to be helpful which gives me:

parse error
= File "drivers/macintosh/windfarm_pm112.c", line 685, column 4, charpos = 17702

    around = 'nr_cores', whole content = 		++nr_cores;

which basically means that it can't handle for_each_node_by_type()?

bad: for_each_node_by_type(cpu, "cpu")
BAD:!!!!! ++nr_cores;

But neither "--include include/linux/of.h" nor "--recursive-includes" does help the case for me?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://systeme.lip6.fr/pipermail/cocci/attachments/20141221/6a5b7940/attachment.asc>

#2 lore raw
Quoted 17 lines · Wolfram Sang
Quoted 10 lines

does not result in anything although three drivers should match IMO with the same pattern as the pmu driver above. Both use platform_driver_register() and both have the .owner field set.

drivers/macintosh/windfarm_pm112.c
drivers/macintosh/windfarm_pm72.c
drivers/macintosh/windfarm_rm31.c

How can I debug why the match does not occur?

So, I found "--verbose-parsing" to be helpful which gives me:

parse error
= File "drivers/macintosh/windfarm_pm112.c", line 685, column 4, charpos = 17702

    around = 'nr_cores', whole content = 		++nr_cores;
Quoted 7 lines

which basically means that it can't handle for_each_node_by_type()?

bad: for_each_node_by_type(cpu, "cpu")
BAD:!!!!! ++nr_cores;

But neither "--include include/linux/of.h" nor "--recursive-includes" does help the case for me?

It is not surprising that adding more includes doesn't help. But I would have thought that for_each_node_by_type, as it begins with for, would be something that it would pick up on. I will take a look.

julia

#3 lore raw
Quoted 24 lines · Julia Lawall
Quoted 22 lines · Wolfram Sang
Quoted 10 lines

does not result in anything although three drivers should match IMO with the same pattern as the pmu driver above. Both use platform_driver_register() and both have the .owner field set.

drivers/macintosh/windfarm_pm112.c
drivers/macintosh/windfarm_pm72.c
drivers/macintosh/windfarm_rm31.c

How can I debug why the match does not occur?

So, I found "--verbose-parsing" to be helpful which gives me:

parse error
= File "drivers/macintosh/windfarm_pm112.c", line 685, column 4, charpos = 17702

    around = 'nr_cores', whole content = 		++nr_cores;

which basically means that it can't handle for_each_node_by_type()?

bad: for_each_node_by_type(cpu, "cpu")
BAD:!!!!! ++nr_cores;

Quoted 6 lines
Quoted 2 lines

But neither "--include include/linux/of.h" nor "--recursive-includes" does help the case for me?

It is not surprising that adding more includes doesn't help. But I would have thought that for_each_node_by_type, as it begins with for, would be something that it would pick up on. I will take a look.

How does coccinelle work with such constructs? I'd think that replacing that #define with the actual for()-construct is much more reliable than an assumption like "it starts with 'for' so it is probably...' :)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <https://systeme.lip6.fr/pipermail/cocci/attachments/20141221/81a1a83a/attachment.asc>

#4 lore raw
Quoted 28 lines · Wolfram Sang
Quoted 27 lines · Julia Lawall
Quoted 24 lines · Wolfram Sang
Quoted 10 lines

does not result in anything although three drivers should match IMO with the same pattern as the pmu driver above. Both use platform_driver_register() and both have the .owner field set.

drivers/macintosh/windfarm_pm112.c
drivers/macintosh/windfarm_pm72.c
drivers/macintosh/windfarm_rm31.c

How can I debug why the match does not occur?

So, I found "--verbose-parsing" to be helpful which gives me:

parse error
= File "drivers/macintosh/windfarm_pm112.c", line 685, column 4, charpos = 17702

    around = 'nr_cores', whole content = 		++nr_cores;

which basically means that it can't handle for_each_node_by_type()?

bad: for_each_node_by_type(cpu, "cpu")
BAD:!!!!! ++nr_cores;

But neither "--include include/linux/of.h" nor "--recursive-includes" does help the case for me?

Quoted 7 lines
Quoted 3 lines

It is not surprising that adding more includes doesn't help. But I would have thought that for_each_node_by_type, as it begins with for, would be something that it would pick up on. I will take a look.

How does coccinelle work with such constructs? I'd think that replacing that #define with the actual for()-construct is much more reliable than an assumption like "it starts with 'for' so it is probably...' :)

When you replace things with other things, then you can't transform them. So it tries to guess. It is possible that the guess only happens when the body of the loop has {}...

julia

#5 lore raw
In reply to Wolfram Sang
Quoted 17 lines · Wolfram Sang
Quoted 10 lines

does not result in anything although three drivers should match IMO with the same pattern as the pmu driver above. Both use platform_driver_register() and both have the .owner field set.

drivers/macintosh/windfarm_pm112.c
drivers/macintosh/windfarm_pm72.c
drivers/macintosh/windfarm_rm31.c

How can I debug why the match does not occur?

So, I found "--verbose-parsing" to be helpful which gives me:

parse error
= File "drivers/macintosh/windfarm_pm112.c", line 685, column 4, charpos = 17702

    around = 'nr_cores', whole content = 		++nr_cores;
Quoted 7 lines

which basically means that it can't handle for_each_node_by_type()?

bad: for_each_node_by_type(cpu, "cpu")
BAD:!!!!! ++nr_cores;

But neither "--include include/linux/of.h" nor "--recursive-includes" does help the case for me?

Here is a patch (band-aid...). It was made on rc23, but it should apply to rc22 just as well.

julia

parsing_c/parsing_hacks.ml +2 -0
index 2a665cd..58b7a14 100644
@@ -324,6 +324,8 @@ let rec is_really_foreach xs =
     | TCPar _::Tfor _::xs -> true, xs
     | TCPar _::Tswitch _::xs -> true, xs
     | TCPar _::Treturn _::xs -> true, xs
+    | TCPar _::TInc _::xs -> true, xs
+    | TCPar _::TDec _::xs -> true, xs
 
 
     | TCPar _::xs -> false, xs