3.17.x 3.18.x nfs_permission(): put_rpccred() missing?
Subsystems (2)
While updating the nfs-ngroups patch for 3.17 and 3.18 I noticed that nfs_permission() seems to be missing a put_rpccred() call in the non -ECHILD path.
Signature · 1 line
Frank
Hi Frank,
Quoted 3 lines · Frank van Maarseveen
While updating the nfs-ngroups patch for 3.17 and 3.18 I noticed that
nfs_permission()seems to be missing aput_rpccred()call in the non-ECHILDpath.
I fully agree that it is confusing, but the current code is actually correct. Please see the changelog for commit bd95608053b7f (sunrpc/auth: allow lockless (rcu) lookup of credential cache.) which explains the rules for the RCU-safe credential lookup.
We definitely do want to document this behaviour a little better in the source. Any takers?
Cheers,
Trond
Signature · 5 lines
Trond Myklebust Linux NFS client maintainer, PrimaryData [email protected]