Skip to contentSkip to conversation

dm bufio: fix time comparison

PATCH New Asaf Vertz 1 participant 1 message Jan 6, 2015

Subsystems (2)
MD RAID Device mapper
lore
Share & tools
lore

Asaf Vertz

author
#0 lore raw

PATCH 1/1 dm bufio: fix time comparison

To be future-proof and for better readability the time comparison modified to use time_after_eq() instead of plain, error-prone math.

Signed-off-by Asaf Vertz <[email protected]>
---
 drivers/md/dm-bufio.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
drivers/md/dm-bufio.c +2 -1
index c33b497..86dbbc7 100644
@@ -11,6 +11,7 @@
 #include <linux/device-mapper.h>
 #include <linux/dm-io.h>
 #include <linux/slab.h>
+#include <linux/jiffies.h>
 #include <linux/vmalloc.h>
 #include <linux/shrinker.h>
 #include <linux/module.h>

@@ -1739,7 +1740,7 @@ static unsigned get_max_age_hz(void)
 
 static bool older_than(struct dm_buffer *b, unsigned long age_hz)
 {
-	return (jiffies - b->last_accessed) >= age_hz;
+	return time_after_eq(jiffies, b->last_accessed + age_hz);
 }
 
 static void __evict_old_buffers(struct dm_bufio_client *c, unsigned long age_hz)
Signature · 1 line
1.7.0.4