Skip to contentSkip to conversation

make mrproper fix for v3.19-rc4

GIT PULL Michal Marek 2 participants 4 messages Jan 8, 2015 – Jan 9, 2015 Kbuild

lore
Share & tools
lore
#0 lore raw

Hi Linus,

make mrproper / distclean stopped removing the generated debian/ directory in v3.16. Please pull the fix.

Thanks,
Michal

The following changes since commit 97bf6af1f928216fd6c5a66e8a57bfa95a659672:

Linux 3.19-rc1 (2014-12-20 17:08:50 -0800)

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild.git

for you to fetch changes up to a16c5f99a28c9945165c46da27fff8e6f26f8736:

kbuild: Fix removal of the debian/ directory (2015-01-02 14:51:27 +0100)

----------------------------------------------------------------
Michal Marek (1):
kbuild: Fix removal of the debian/ directory

 scripts/Makefile.clean | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)
#1 lore raw
Quoted 8 lines · Michal Marek

Hi Linus,

make mrproper / distclean stopped removing the generated debian/ directory in v3.16. Please pull the fix.

Thanks,
Michal

Quoted 7 lines

The following changes since commit 97bf6af1f928216fd6c5a66e8a57bfa95a659672:

Linux 3.19-rc1 (2014-12-20 17:08:50 -0800)

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild.git

Sorry, git-request-pull for some reason does not see the commit in the remote repository and did not print the branch name here. But it is there, please pull from

git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild.git rc-fixes

Thanks,
Michal

#2 lore raw
In reply to Michal Marek
Quoted 3 lines · Michal Marek

make mrproper / distclean stopped removing the generated debian/ directory in v3.16.

So "make distclean" still doesn't actually clean everything.

I don't personally much care, since I've taught my fingers to just do

git clean -dqfx

instead, but since I tested "make distclean" after pulling from you, I thought I'd just mention it.

Just do

make allmodconfig
.. build the tree ..
make distclean
git ls-files -o

to see any files that are left-over despite the distclean ("git ls-files -o" basically shows all untracked files - 'o' stands for 'others' - so anything that isn't in the actual distributed sources shows up)

But I really am not sure how much effort we should spend on "make distclean", given than "git clean" is so much easier and requires no effort at all.

Linus

#3 lore raw
Quoted 11 lines · Linus Torvalds

Just do

make allmodconfig
.. build the tree ..
make distclean
git ls-files -o

to see any files that are left-over despite the distclean ("git ls-files -o" basically shows all untracked files - 'o' stands for 'others' - so anything that isn't in the actual distributed sources shows up)

The x86 files should actually be removed by make clean. The bug is that the $(targets) variable must not depend on the configuration, so that make clean always knows what to delete. I'll send a patch to the x86 maintainers, but such bugs keep creeping in. Other archs possibly have a similar prolbem.

security/tomoyo automatically generates files that can also be supplied by the user, which sucks, because make clean does not know whether they are generated or user supplied.

Quoted 3 lines

But I really am not sure how much effort we should spend on "make distclean", given than "git clean" is so much easier and requires no effort at all.

With git clean and git archive, there is indeed little use for make distclean. But clean and mrproper should work.

Michal