Skip to contentSkip to conversation

ALSA: hda - Enable mic mute hotkey and LEDs for an HP machine

DISCUSSION Dan Carpenter 1 participant 1 message Jan 10, 2015

lore
Share & tools
lore
#0 lore raw

Hello David Henningsson,

The patch 33f4acd3b214: "ALSA: hda - Enable mic mute hotkey and LEDs for an HP machine" from Jan 7, 2015, leads to the following static checker warning:

	sound/pci/hda/patch_realtek.c:3551 alc280_fixup_hp_gpio2_mic_hotkey()
	error: don't call input_free_device() after input_unregister_device()

sound/pci/hda/patch_realtek.c
3545 switch (action) {
3546 case HDA_FIXUP_ACT_PROBE:
3547 spec->init_amp = ALC_INIT_DEFAULT;
3548 break;
3549 case HDA_FIXUP_ACT_FREE:
3550 input_unregister_device(spec->kb_dev);
3551 input_free_device(spec->kb_dev);

I think this is a double free.

  3552                  spec->kb_dev = NULL;
  3553          }
  3554  #endif
  3555  }

regards,
dan carpenter