static symbols in credit2

Changing param varibales in sched_credit2.c as static where required.

---

index 1ca521b..9dd8e84 100644
@@ -163,7 +163,7 @@
 #define CSFLAG_runq_migrate_request (1<<__CSFLAG_runq_migrate_request)
 
 
-int opt_migrate_resist=500;
+static int opt_migrate_resist = 500;
 integer_param("sched_credit2_migrate_resist", opt_migrate_resist);
 
 /*

@@ -186,12 +186,12 @@ integer_param("sched_credit2_migrate_resist", opt_migrate_resist);
  *   to a load of 1.
  */
 #define LOADAVG_GRANULARITY_SHIFT (10)
-int opt_load_window_shift=18;
+static int opt_load_window_shift = 18;
 #define  LOADAVG_WINDOW_SHIFT_MIN 4
 integer_param("credit2_load_window_shift", opt_load_window_shift);
-int opt_underload_balance_tolerance=0;
+static int opt_underload_balance_tolerance = 0;
 integer_param("credit2_balance_under", opt_underload_balance_tolerance);
-int opt_overload_balance_tolerance=-3;
+static int opt_overload_balance_tolerance = -3;
 integer_param("credit2_balance_over", opt_overload_balance_tolerance);
 
 /*

Hi Uma,

AFAICT, this is the second version of the patch, that you produced after receiving feedback on your first submission, isn't it? In that case, you should make that evident in the subject, using something like "[PATCH v2]"

And also, you should put a summary of what changed in this new submission, wrt the previous one(s). We usually put it here, in the changelog, below the '---' marker.

In this case, that is pretty straightforward, but please do, if only to get used to it! :-)

<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Sorry for the delay -- everything looks good code-wise; but it probably makes sense to send v3 with Dario's suggestions.

-George

Hi,

Dariof, I am not able to understand the last statement.

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-devel

Hi,

Sorry for being less responsive these days. Was facing some health issues (cold).
Hope I can start work from tomorrow. :-)

Sorry Dariof I did not get this statement "what about "__read_mostly" as an attribute (for others too) ?"
Is it about making other variables __initdata ?

Regards,
Uma Sharma
http://about.me/umasharma