staging: wlan-ng: hfa384x_usb: fix sparse endianness warnings
PATCH 1/1 staging: wlan-ng: hfa384x_usb: fix sparse endianness warnings
Fixed the following warnings (reported by sparse):drivers/staging/wlan-ng/hfa384x_usb.c:3828:36: warning: cast to restricted __le16 drivers/staging/wlan-ng/hfa384x_usb.c:3229:16: warning: cast to restricted __le16 drivers/staging/wlan-ng/hfa384x_usb.c:3430:18: warning: cast to restricted __le16 drivers/staging/wlan-ng/hfa384x_usb.c:3349:51: warning: restricted __le16 degrades to integer drivers/staging/wlan-ng/hfa384x_usb.c:3357:37: warning: cast to restricted __le16 drivers/staging/wlan-ng/hfa384x_usb.c:3358:37: warning: cast to restricted __le16 drivers/staging/wlan-ng/hfa384x_usb.c:3393:36: warning: cast to restricted __le16 drivers/staging/wlan-ng/hfa384x_usb.c:3102:28: warning: cast to restricted __le16 drivers/staging/wlan-ng/hfa384x_usb.c:3004:28: warning: cast to restricted __le16 drivers/staging/wlan-ng/hfa384x_usb.c:1308:37: warning: cast to restricted __le16 drivers/staging/wlan-ng/hfa384x_usb.c:2713:25: warning: incorrect type in assignment (different base types)drivers/staging/wlan-ng/hfa384x_usb.c:2713:25: expected unsigned short [unsigned] [usertype] typedrivers/staging/wlan-ng/hfa384x_usb.c:2713:25: got restricted __le16 [usertype] <noident>
--- drivers/staging/wlan-ng/hfa384x.h | 4 ++-- drivers/staging/wlan-ng/hfa384x_usb.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)
drivers/staging/wlan-ng/hfa384x.h +2 -2
@@ -879,7 +879,7 @@ typedef struct hfa384x_usb_error {/* Unions for packaging all the known packet types together */ typedef union hfa384x_usbout { - u16 type; + __le16 type; hfa384x_usb_txfrm_t txfrm; hfa384x_usb_cmdreq_t cmdreq; hfa384x_usb_wridreq_t wridreq;
@@ -889,7 +889,7 @@ typedef union hfa384x_usbout { }__packed hfa384x_usbout_t; typedef union hfa384x_usbin { - u16 type; + __le16 type; hfa384x_usb_rxfrm_t rxfrm; hfa384x_usb_txfrm_t txfrm; hfa384x_usb_infofrm_t infofrm;
drivers/staging/wlan-ng/hfa384x_usb.c +1 -1
@@ -3346,7 +3346,7 @@ retry:if (unlocked_usbctlx_cancel_async (hw, ctlx) ==0 ) run_queue =1 ; }else { -const u16 intype = (usbin->type & ~cpu_to_le16 (0x8000 )); +const __le16 intype = (usbin->type & ~cpu_to_le16 (0x8000 ));/* * Check that our message is what we're expecting ...
Signature · 1 line
1.7.0.4
Quoted 15 lines · Asaf Vertz
Fixed the following warnings (reported by sparse):
drivers/staging/wlan-ng/hfa384x_usb.c:3828:36: warning: cast to restricted__le16drivers/staging/wlan-ng/hfa384x_usb.c:3229:16: warning: cast to restricted__le16drivers/staging/wlan-ng/hfa384x_usb.c:3430:18: warning: cast to restricted__le16drivers/staging/wlan-ng/hfa384x_usb.c:3349:51: warning: restricted__le16degrades to integerdrivers/staging/wlan-ng/hfa384x_usb.c:3357:37: warning: cast to restricted__le16drivers/staging/wlan-ng/hfa384x_usb.c:3358:37: warning: cast to restricted__le16drivers/staging/wlan-ng/hfa384x_usb.c:3393:36: warning: cast to restricted__le16drivers/staging/wlan-ng/hfa384x_usb.c:3102:28: warning: cast to restricted__le16drivers/staging/wlan-ng/hfa384x_usb.c:3004:28: warning: cast to restricted__le16drivers/staging/wlan-ng/hfa384x_usb.c:1308:37: warning: cast to restricted__le16drivers/staging/wlan-ng/hfa384x_usb.c:2713:25: warning: incorrect type in assignment (different base types)drivers/staging/wlan-ng/hfa384x_usb.c:2713:25: expected unsigned short [unsigned] [usertype] typedrivers/staging/wlan-ng/hfa384x_usb.c:2713:25: got restricted__le16[usertype] <noident>
Quoted 5 lines
Signed-off-by Asaf Vertz <[email protected]>--- drivers/staging/wlan-ng/hfa384x.h | 4 ++-- drivers/staging/wlan-ng/hfa384x_usb.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)
Applied, thanks.
greg k-h