Skip to contentSkip to conversation

staging: iio: tsl2583: fix format string warnings

PATCH Applied Asaf Vertz 2 participants 2 messages Jan 20, 2015

Subsystems (3)
lore
Share & tools
lore

Asaf Vertz

author
#0 lore raw

PATCH 1/1 staging: iio: tsl2583: fix format string warnings

Fixed the following warnings (reported by cppcheck):
[drivers/staging/iio/light/tsl2583.c:695]: (warning) %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [drivers/staging/iio/light/tsl2583.c:695]: (warning) %d in format string (no. 2) requires 'int' but the argument type is 'unsigned int'. [drivers/staging/iio/light/tsl2583.c:695]: (warning) %d in format string (no. 3) requires 'int' but the argument type is 'unsigned int'.

---
 drivers/staging/iio/light/tsl2583.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/staging/iio/light/tsl2583.c +1 -1
index cc4ddcc..8afae8e 100644
@@ -692,7 +692,7 @@ static ssize_t taos_luxtable_show(struct device *dev,
 	int offset = 0;
 
 	for (i = 0; i < ARRAY_SIZE(taos_device_lux); i++) {
-		offset += sprintf(buf + offset, "%d,%d,%d,",
+		offset += sprintf(buf + offset, "%u,%u,%u,",
 				  taos_device_lux[i].ratio,
 				  taos_device_lux[i].ch0,
 				  taos_device_lux[i].ch1);
Signature · 1 line
1.7.0.4
maintainer Applied
#1 lore raw
Quoted 9 lines · Asaf Vertz

Fixed the following warnings (reported by cppcheck):
[drivers/staging/iio/light/tsl2583.c:695]: (warning) %d in format string (no. 1) requires 'int' but the argument type is 'unsigned int'. [drivers/staging/iio/light/tsl2583.c:695]: (warning) %d in format string (no. 2) requires 'int' but the argument type is 'unsigned int'. [drivers/staging/iio/light/tsl2583.c:695]: (warning) %d in format string (no. 3) requires 'int' but the argument type is 'unsigned int'.

Applied to the togreg branch of iio.git - initially pushed out as testing. Note this branch will almost certainly get rebased before going upstream.

Jonathan

Quoted 18 lines
---
 drivers/staging/iio/light/tsl2583.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/staging/iio/light/tsl2583.c +1 -1
index cc4ddcc..8afae8e 100644
@@ -692,7 +692,7 @@ static ssize_t taos_luxtable_show(struct device *dev,
 	int offset = 0;
 
 	for (i = 0; i < ARRAY_SIZE(taos_device_lux); i++) {
-		offset += sprintf(buf + offset, "%d,%d,%d,",
+		offset += sprintf(buf + offset, "%u,%u,%u,",
 				  taos_device_lux[i].ratio,
 				  taos_device_lux[i].ch0,
 				  taos_device_lux[i].ch1);