mmc: dw_mmc: rockchip: remove incorrect __exit_p()

PATCH Applied Dmitry Torokhov 3 participants 3 messages Jan 24, 2015 – Jan 27, 2015

Subsystems (3)

MMC, SD and SDIO Arm Rockchip Synopsys DesignWare MMC/SD/SDIO driver

lore

Share & tools

lore

Dmitry Torokhov

author

2015-01-24 00:30 UTC #0 lore raw

PATCH 1/1 mmc: dw_mmc: rockchip: remove incorrect __exit_p()

dw_mci_pltfm_remove() is not (nor should it be) marked as __exit, so we should not be using __exit_p() wrapper with it.

Signed-off-by Dmitry Torokhov <[email protected]>

---
 drivers/mmc/host/dw_mmc-rockchip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/mmc/host/dw_mmc-rockchip.c +1 -1

index 5650ac4..e2a726a 100644
@@ -133,7 +133,7 @@ static SIMPLE_DEV_PM_OPS(dw_mci_rockchip_pmops,
 
 static struct platform_driver dw_mci_rockchip_pltfm_driver = {
 	.probe		= dw_mci_rockchip_probe,
-	.remove		= __exit_p(dw_mci_pltfm_remove),
+	.remove		= dw_mci_pltfm_remove,
 	.driver		= {
 		.name		= "dwmmc_rockchip",
 		.of_match_table	= dw_mci_rockchip_match,

Signature · 5 lines

2.2.0.rc0.207.ga3a616c


-- 
Dmitry

Doug Anderson

Reviewed-by Tested-by on v1 1/1

2015-01-26 20:50 UTC #1 lore raw

Dmitry,

Quoted 7 lines · Dmitry Torokhov

dw_mci_pltfm_remove() is not (nor should it be) marked as __exit, so we should not be using __exit_p() wrapper with it.
Signed-off-by Dmitry Torokhov <[email protected]>
---
 drivers/mmc/host/dw_mmc-rockchip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Nice catch, thanks!

Reviewed-by Doug Anderson <[email protected]>

Tested-by Doug Anderson <[email protected]>

Ulf Hansson

Applied

2015-01-27 13:59 UTC #2 lore raw

In reply to Dmitry Torokhov

Quoted 4 lines · Dmitry Torokhov

dw_mci_pltfm_remove() is not (nor should it be) marked as __exit, so we should not be using __exit_p() wrapper with it.
Signed-off-by Dmitry Torokhov <[email protected]>

Thanks! Applied for next.

Kind regards
Uffe

Quoted 23 lines

---
 drivers/mmc/host/dw_mmc-rockchip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/mmc/host/dw_mmc-rockchip.c +1 -2

index 5650ac4..e2a726a 100644
@@ -133,7 +133,7 @@ static SIMPLE_DEV_PM_OPS(dw_mci_rockchip_pmops,
 
 static struct platform_driver dw_mci_rockchip_pltfm_driver = {
        .probe          = dw_mci_rockchip_probe,
-       .remove         = __exit_p(dw_mci_pltfm_remove),
+       .remove         = dw_mci_pltfm_remove,
        .driver         = {
                .name           = "dwmmc_rockchip",
                .of_match_table = dw_mci_rockchip_match,
--

2.2.0.rc0.207.ga3a616c

--
Dmitry