Skip to contentSkip to conversation

staging: rtl8712: fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...

PATCH Superseded Heba Aamer 3 participants 4 messages Jan 24, 2015 – Jan 26, 2015 Staging

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Heba Aamer

author
#0 lore raw

PATCH 1/1 staging: rtl8712: fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...

This patch fixes the following checkpatch.pl warning:
fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...

netdev_info was used since it is a network subsystem

---
 drivers/staging/rtl8712/usb_intf.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8712/usb_intf.c +1 -1
index 7d0d171..7748a75 100644
@@ -366,7 +366,7 @@ static int r871xu_drv_init(struct usb_interface *pusb_intf,
 	struct net_device *pnetdev;
 	struct usb_device *udev;
 
-	printk(KERN_INFO "r8712u: Staging version\n");
+	netdev_info(pnetdev, "r8712u: Staging version\n");
 	/* In this probe function, O.S. will provide the usb interface pointer
 	 * to driver. We have to increase the reference count of the usb device
 	 * structure by using the usb_get_dev function.
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 16 lines · Heba Aamer

This patch fixes the following checkpatch.pl warning:
fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...

netdev_info was used since it is a network subsystem

---
 drivers/staging/rtl8712/usb_intf.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8712/usb_intf.c +0 -0
index 7d0d171..7748a75 100644

drivers/staging/rtl8712/usb_intf.c static int r871xu_drv_init(struct usb_interface *pusb_intf, · line 369

Quoted 5 lines
drivers/staging/rtl8712/usb_intf.c +1 -1
@@ -366,7 +366,7 @@ static int r871xu_drv_init(struct usb_interface *pusb_intf,
 	struct net_device *pnetdev;
 	struct usb_device *udev;
 
-	printk(KERN_INFO "r8712u: Staging version\n");
+	netdev_info(pnetdev, "r8712u: Staging version\n");

I've applied your patch and there is one problem here, pnetdev is not initialized yet. It's better to use pr_info for now.

Kind Regards,
Aya Saif El-yazal Mahfouz

Quoted 10 lines
drivers/staging/rtl8712/usb_intf.c +0 -0
 	/* In this probe function, O.S. will provide the usb interface pointer
 	 * to driver. We have to increase the reference count of the usb device
 	 * structure by using the usb_get_dev function.
Signature · 6 lines
1.7.9.5

_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
maintainer
#2 lore raw
In reply to Heba Aamer
Quoted 16 lines · Heba Aamer

This patch fixes the following checkpatch.pl warning:
fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...

netdev_info was used since it is a network subsystem

---
 drivers/staging/rtl8712/usb_intf.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8712/usb_intf.c +0 -0
index 7d0d171..7748a75 100644

drivers/staging/rtl8712/usb_intf.c static int r871xu_drv_init(struct usb_interface *pusb_intf, · line 372

Quoted 8 lines
drivers/staging/rtl8712/usb_intf.c +1 -1
@@ -366,7 +366,7 @@ static int r871xu_drv_init(struct usb_interface *pusb_intf,
 	struct net_device *pnetdev;
 	struct usb_device *udev;
 
-	printk(KERN_INFO "r8712u: Staging version\n");
+	netdev_info(pnetdev, "r8712u: Staging version\n");
 	/* In this probe function, O.S. will provide the usb interface pointer
 	 * to driver. We have to increase the reference count of the usb device
 	 * structure by using the usb_get_dev function.

Please don't send patches that you do not at least test-build, it's a bit rude and wastes people's time.

Oh, and also ensure that your patch is correct, hint, this one does not work at all :(

greg k-h

author
#3 lore raw
Quoted 20 lines · Greg KH
Quoted 19 lines · Heba Aamer

This patch fixes the following checkpatch.pl warning:
fix Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...

netdev_info was used since it is a network subsystem

---
 drivers/staging/rtl8712/usb_intf.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8712/usb_intf.c +0 -0
index 7d0d171..7748a75 100644
@@ -366,7 +366,7 @@ static int r871xu_drv_init(struct usb_interface *pusb_intf,
 	struct net_device *pnetdev;
 	struct usb_device *udev;
 
Quoted 9 lines

drivers/staging/rtl8712/usb_intf.c static int r871xu_drv_init(struct usb_interface *pusb_intf, · line 372

Quoted 5 lines
drivers/staging/rtl8712/usb_intf.c +1 -1
-	printk(KERN_INFO "r8712u: Staging version\n");
+	netdev_info(pnetdev, "r8712u: Staging version\n");
 	/* In this probe function, O.S. will provide the usb interface pointer
 	 * to driver. We have to increase the reference count of the usb device
 	 * structure by using the usb_get_dev function.

Please don't send patches that you do not at least test-build, it's a bit rude and wastes people's time.

Sorry Greg! I did build the module but it was cached. I built the driver again after cleaning it, and I did find a warning related to my patch. I had a question though, I found a warning related to an unused function. Here is the warning:

drivers/staging/rtl8712/rtl871x_mp_ioctl.c:708:12: warning:
‘mp_query_drv_var’ defined but not used [-Wunused-function]

Should I remove this function or should I keep it as is? If it will be removed, I will send it in a different patch.

Quoted 2 lines

Oh, and also ensure that your patch is correct, hint, this one does not work at all :(

Sorry again and I will be sending the new patch soon.

Quoted 2 lines

greg k-h

Heba Aamer