Skip to contentSkip to conversation

ocfs2: removes mlog_errno() call twice in ocfs2_find_dir_space_el()

PATCH New Daeseok Youn 1 participant 1 message Jan 29, 2015 OCFS2

lore
Share & tools
lore
#0 lore raw

PATCH 2/3 ocfs2: removes mlog_errno() call twice in ocfs2_find_dir_space_el()

The mlog_errno() function is called twice when some functions are failed.

---
 fs/ocfs2/dir.c |    9 +++------
 1 files changed, 3 insertions(+), 6 deletions(-)
fs/ocfs2/dir.c +3 -6
index 940be6d..b08050b 100644
@@ -3456,10 +3456,8 @@ static int ocfs2_find_dir_space_el(struct inode *dir, const char *name,
 	int blocksize = dir->i_sb->s_blocksize;
 
 	status = ocfs2_read_dir_block(dir, 0, &bh, 0);
-	if (status) {
-		mlog_errno(status);
+	if (status)
 		goto bail;
-	}
 
 	rec_len = OCFS2_DIR_REC_LEN(namelen);
 	offset = 0;
@@ -3480,10 +3478,9 @@ static int ocfs2_find_dir_space_el(struct inode *dir, const char *name,
 			status = ocfs2_read_dir_block(dir,
 					     offset >> sb->s_blocksize_bits,
 					     &bh, 0);
-			if (status) {
-				mlog_errno(status);
+			if (status)
 				goto bail;
-			}
+
 			/* move to next block */
 			de = (struct ocfs2_dir_entry *) bh->b_data;
 		}
Signature · 1 line
1.7.1