Skip to contentSkip to conversation

drm/nouveau/mmu: shift wrapping bug in gf100_vm_map()

PATCH New Dan Carpenter 1 participant 1 message Feb 9, 2015

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/nouveau/mmu: shift wrapping bug in gf100_vm_map()

Since "1" is an int, then it means we can't use the high bits of this u64.

drivers/gpu/drm/nouveau/nvkm/subdev/mmu/gf100.c +1 -1
index 294cda3..b10c90a 100644
@@ -106,7 +106,7 @@ static void
 gf100_vm_map(struct nvkm_vma *vma, struct nvkm_gpuobj *pgt,
 	     struct nvkm_mem *mem, u32 pte, u32 cnt, u64 phys, u64 delta)
 {
-	u64 next = 1 << (vma->node->type - 8);
+	u64 next = 1ULL << (vma->node->type - 8);
 
 	phys  = gf100_vm_addr(vma, phys, mem->memtype, 0);
 	pte <<= 3;

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel